Re: [PATCH v2 1/2] qcow2: handle discard-no-unref in measure

2025-03-27 Thread Jean-Louis Dupond
Any chance this can get reviewed and perhaps merged? We would like to enable discard-no-unref by default on oVirt, as this makes qcow2 inside LVM LV's way more reliable (because we can calculate the size). But we are still missing this measure patch to be able to properly calculate the destina

Re: [PATCH v2 1/2] qcow2: handle discard-no-unref in measure

2025-02-17 Thread Jean-Louis Dupond
Hi, First of all sorry for the huge delay, but didn't had time to follow-up on this lately. And it got some lower priority, as we don't hit it often and have a fairly easy workaround (fill the empty blocks again in the snapshot by writing data to the disk). On 7/10/24 14:58, Hanna Czenczek w

Re: [PATCH v2 1/2] qcow2: handle discard-no-unref in measure

2024-07-10 Thread Hanna Czenczek
On 05.06.24 15:25, Jean-Louis Dupond wrote: When doing a measure on an image with a backing file and discard-no-unref is enabled, the code should take this into account. That doesn’t make sense to me.  As far as I understand, 'measure' is supposed to report how much space you need for a given

[PATCH v2 1/2] qcow2: handle discard-no-unref in measure

2024-06-05 Thread Jean-Louis Dupond
When doing a measure on an image with a backing file and discard-no-unref is enabled, the code should take this into account. If for example you have a snapshot image with a base, and you do a discard within the snapshot, it will be ZERO and ALLOCATED, but without host offset. Now if we commit thi