On Wed, 3 Mar 2021 08:07:50 +0100
Gerd Hoffmann wrote:
> Hi,
>
> > The only approaches I can think of to make type_register_mayfail()
> > "work" involve adding a dependency check in type_register_internal()
> > before the call to type_table_add() is made. This can "work" for modules,
> > becau
Hi,
> The only approaches I can think of to make type_register_mayfail()
> "work" involve adding a dependency check in type_register_internal()
> before the call to type_table_add() is made. This can "work" for modules,
> because for types loaded from we can hope, that all dependencies are
> alr
On Wed, 24 Feb 2021 17:46:34 +0100
Halil Pasic wrote:
> On Wed, 24 Feb 2021 12:36:17 +0100
> Gerd Hoffmann wrote:
[..]
> >
> > > -static TypeImpl *type_register_internal(const TypeInfo *info)
> > > +static TypeImpl *type_register_internal(const TypeInfo *info, bool
> > > mayfail)
> > > {
>
Hi,
> a programming error. So I'm absolutely against shoving this logic
> down into object.c. But I find the variant I posted nicer to document
> and nicer to read: looking at virtio_ccw_gpu_register() one sees
> immediately that if built as a module, it is OK if the registration
> fails, and if
On Wed, 24 Feb 2021 12:36:17 +0100
Gerd Hoffmann wrote:
> > static void virtio_ccw_gpu_register(void)
> > {
> > +#ifdef CONFIG_MODULES
> > +type_register_static_mayfail(&virtio_ccw_gpu);
> > +#else
> > type_register_static(&virtio_ccw_gpu);
> > +#endif
>
> Move the ifdef to type_reg
> static void virtio_ccw_gpu_register(void)
> {
> +#ifdef CONFIG_MODULES
> +type_register_static_mayfail(&virtio_ccw_gpu);
> +#else
> type_register_static(&virtio_ccw_gpu);
> +#endif
Move the ifdef to type_register_static_mayfail, so this is not
duplicated for every module which might n
On Mon, 22 Feb 2021 17:30:50 +
Daniel P. Berrangé wrote:
> > Paolo, Daniel,
> > I am in general (s390 unrelated) a bit puzzled about the scenario of QEMU
> > being modularized.
> > Libvirt probes QEMU executables for their capabilities and creates a
> > capabilities cache of the probed QEMU b
On Mon, Feb 22, 2021 at 06:18:57PM +0100, Boris Fiuczynski wrote:
> Paolo, Daniel,
> I am in general (s390 unrelated) a bit puzzled about the scenario of QEMU
> being modularized.
> Libvirt probes QEMU executables for their capabilities and creates a
> capabilities cache of the probed QEMU binary.
Paolo, Daniel,
I am in general (s390 unrelated) a bit puzzled about the scenario of
QEMU being modularized.
Libvirt probes QEMU executables for their capabilities and creates a
capabilities cache of the probed QEMU binary. There are a few triggers
that invalidate the cache. One is the QEMU bina
Since the virtio-gpu-ccw device depends on the hw-display-virtio-gpu
module, which provides the type virtio-gpu-device, packaging the
hw-display-virtio-gpu module as a separate package that may or may not
be installed along with the qemu package leads to problems. Namely if
the hw-display-virtio-gp
10 matches
Mail list logo
