Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-25 Thread Kele Huang
Got it. Thank you again! I have resend a brand new v3 patch. On Thu, 24 Sep 2020 at 22:05, Richard Henderson < richard.hender...@linaro.org> wrote: > On 9/23/20 2:38 AM, Kele Huang wrote: > > Detect mips store instructions in cpu_signal_handler for all MIPS > > versions, and set is_write if encou

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-24 Thread Richard Henderson
On 9/23/20 2:38 AM, Kele Huang wrote: > Detect mips store instructions in cpu_signal_handler for all MIPS > versions, and set is_write if encountering such store instructions. > > This fixed the error while dealing with self-modifed code for MIPS. > > Signed-off-by: Kele Huang > Signed-off-by: X

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-24 Thread Kele Huang
Sorry about my misunderstanding of your guidelines. What is more, I have resend a new v2 patch as a new top-level thread and CC to TCG MIPS maintainers and Richard. On Wed, 23 Sep 2020 at 19:08, Philippe Mathieu-Daudé wrote: > Cc'ing the TCG MIPS maintainers, and also > Cc'ing Richard who made a

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-24 Thread Kele Huang
Got it. Thank you very much! I will resend the same v2 patch to v1 thread. On Wed, 23 Sep 2020 at 19:08, Philippe Mathieu-Daudé wrote: > Cc'ing the TCG MIPS maintainers, and also > Cc'ing Richard who made a comment in v1. > > On 9/23/20 11:38 AM, Kele Huang wrote: > > Detect mips store instructi

Re: [PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-23 Thread Philippe Mathieu-Daudé
Cc'ing the TCG MIPS maintainers, and also Cc'ing Richard who made a comment in v1. On 9/23/20 11:38 AM, Kele Huang wrote: > Detect mips store instructions in cpu_signal_handler for all MIPS > versions, and set is_write if encountering such store instructions. > > This fixed the error while dealin

[PATCH v2 1/1] accel/tcg: Fix computing of is_write for mips

2020-09-23 Thread Kele Huang
Detect mips store instructions in cpu_signal_handler for all MIPS versions, and set is_write if encountering such store instructions. This fixed the error while dealing with self-modifed code for MIPS. Signed-off-by: Kele Huang Signed-off-by: Xu Zou --- accel/tcg/user-exec.c | 51 +