Re: [PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2021-01-01 Thread BALATON Zoltan via
On Fri, 1 Jan 2021, Philippe Mathieu-Daudé wrote: On 12/28/20 3:08 AM, BALATON Zoltan via wrote: Drop DPRINTF and use trace functions instead. Two debug messages about unimplemented registers could be converted to qemu_log_mask() but in reality all registers are currently unimplemented (we just

Re: [PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2021-01-01 Thread BALATON Zoltan via
On Fri, 1 Jan 2021, Philippe Mathieu-Daudé wrote: On 12/28/20 3:08 AM, BALATON Zoltan via wrote: Drop DPRINTF and use trace functions instead. Two debug messages about unimplemented registers could be converted to qemu_log_mask() but in reality all registers are currently unimplemented (we just

Re: [PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2021-01-01 Thread Philippe Mathieu-Daudé
On 12/28/20 3:08 AM, BALATON Zoltan via wrote: > Drop DPRINTF and use trace functions instead. Two debug messages about > unimplemented registers could be converted to qemu_log_mask() but in > reality all registers are currently unimplemented (we just store and > return values of writable regs but

[PATCH v2 09/10] vt82c686: Convert debug printf to trace points

2020-12-27 Thread BALATON Zoltan via
Drop DPRINTF and use trace functions instead. Two debug messages about unimplemented registers could be converted to qemu_log_mask() but in reality all registers are currently unimplemented (we just store and return values of writable regs but do nothing with them). As we already trace register acc