Re: [PATCH v2 08/14] gdbstub: extend GByteArray to read register helpers

2019-12-01 Thread Richard Henderson
On 11/30/19 8:45 AM, Alex Bennée wrote: > -static int cpu_read_virt_reg(CPUS390XState *env, uint8_t *mem_buf, int n) > +static int cpu_read_virt_reg(CPUS390XState *env, GByteArray *mem_buf, int n) > { > switch (n) { > case S390_VIRT_CKC_REGNUM: > @@ -296,9 +296,9 @@ static int cpu_write_

[PATCH v2 08/14] gdbstub: extend GByteArray to read register helpers

2019-11-30 Thread Alex Bennée
Instead of passing a pointer to memory now just extend the GByteArray to all the read register helpers. They can then safely append their data through the normal way. We don't bother with this abstraction for write registers as we have already ensured the buffer being copied from is the correct siz