Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-23 Thread Peter Xu
On Fri, Dec 20, 2024 at 10:38:40PM +0100, Philippe Mathieu-Daudé wrote: > > OTOH, this works for me: > > > > ===8<=== > > diff --git a/linux-user/main.c b/linux-user/main.c > > index b09af8d436..009b7695f2 100644 > > --- a/linux-user/main.c > > +++ b/linux-user/main.c > > @@ -819,6 +819,11 @@ int

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-20 Thread Philippe Mathieu-Daudé
On 20/12/24 18:24, Peter Xu wrote: On Fri, Dec 20, 2024 at 12:25:44PM +0100, Philippe Mathieu-Daudé wrote: On 19/12/24 19:27, Philippe Mathieu-Daudé wrote: On 19/12/24 19:20, Philippe Mathieu-Daudé wrote: On 21/11/24 20:21, Peter Xu wrote: Currently, qdev_get_machine() has a slight misuse on

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-20 Thread Peter Xu
On Fri, Dec 20, 2024 at 12:25:44PM +0100, Philippe Mathieu-Daudé wrote: > On 19/12/24 19:27, Philippe Mathieu-Daudé wrote: > > On 19/12/24 19:20, Philippe Mathieu-Daudé wrote: > > > On 21/11/24 20:21, Peter Xu wrote: > > > > Currently, qdev_get_machine() has a slight misuse on container_get(), as >

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-20 Thread Philippe Mathieu-Daudé
On 19/12/24 19:27, Philippe Mathieu-Daudé wrote: On 19/12/24 19:20, Philippe Mathieu-Daudé wrote: On 21/11/24 20:21, Peter Xu wrote: Currently, qdev_get_machine() has a slight misuse on container_get(), as the helper says "get a container" but in reality the goal is to get the machine object. 

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-19 Thread Philippe Mathieu-Daudé
On 19/12/24 19:20, Philippe Mathieu-Daudé wrote: On 21/11/24 20:21, Peter Xu wrote: Currently, qdev_get_machine() has a slight misuse on container_get(), as the helper says "get a container" but in reality the goal is to get the machine object.  It is still a "container" but not strictly. Note

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-12-19 Thread Philippe Mathieu-Daudé
On 21/11/24 20:21, Peter Xu wrote: Currently, qdev_get_machine() has a slight misuse on container_get(), as the helper says "get a container" but in reality the goal is to get the machine object. It is still a "container" but not strictly. Note that it _may_ get a container (at "/machine") in o

[PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-11-21 Thread Peter Xu
Currently, qdev_get_machine() has a slight misuse on container_get(), as the helper says "get a container" but in reality the goal is to get the machine object. It is still a "container" but not strictly. Note that it _may_ get a container (at "/machine") in our current unit test of test-qdev-glo

Re: [PATCH v2 08/13] qdev: Make qdev_get_machine() not use container_get()

2024-11-21 Thread Philippe Mathieu-Daudé
On 21/11/24 20:21, Peter Xu wrote: Currently, qdev_get_machine() has a slight misuse on container_get(), as the helper says "get a container" but in reality the goal is to get the machine object. It is still a "container" but not strictly. Note that it _may_ get a container (at "/machine") in o