Re: [PATCH v2 06/12] bsd-user: Helper routines h2t_old_sysctl

2023-02-14 Thread Warner Losh
On Tue, Feb 14, 2023 at 2:16 PM Richard Henderson < richard.hender...@linaro.org> wrote: > On 2/13/23 14:27, Warner Losh wrote: > > +/* > > + * Convert the old value from host to target. > > host vs guest is clearer language; "target" gets overloaded, even though > still present in > the code base

Re: [PATCH v2 06/12] bsd-user: Helper routines h2t_old_sysctl

2023-02-14 Thread Richard Henderson
On 2/13/23 14:27, Warner Losh wrote: +/* + * Convert the old value from host to target. host vs guest is clearer language; "target" gets overloaded, even though still present in the code base. + * + * For LONG and ULONG on ABI32, we need to 'down convert' the 8 byte quantities + * to 4 byte

[PATCH v2 06/12] bsd-user: Helper routines h2t_old_sysctl

2023-02-13 Thread Warner Losh
h2t_old_sysctl does the byte swapping in the data to return it to the target for the 'well known' types. Co-Authored-by: Sean Bruno Signed-off-by: Sean Bruno Co-Authored-by: Juergen Lock Signed-off-by: Juergen Lock Co-Authored-by: Raphael Kubo da Costa Signed-off-by: Raphael Kubo da Costa Co