Re: [PATCH v2 06/11] tests/qtest/migration-test: Reduce 'cmd_source' string scope

2023-01-20 Thread Philippe Mathieu-Daudé
On 20/1/23 10:02, Thomas Huth wrote: On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé ---   tests/qtest/migration-test.c | 29 +++--   1 file changed, 15 insertions(+), 14 deletions(-) Missing explanation in the commit description

Re: [PATCH v2 06/11] tests/qtest/migration-test: Reduce 'cmd_source' string scope

2023-01-20 Thread Thomas Huth
On 19/01/2023 15.58, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) Missing explanation in the commit description. What's the benefit of doing this?

Re: [PATCH v2 06/11] tests/qtest/migration-test: Reduce 'cmd_source' string scope

2023-01-19 Thread Richard Henderson
On 1/19/23 04:58, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) Reviewed-by: Richard Henderson r~

[PATCH v2 06/11] tests/qtest/migration-test: Reduce 'cmd_source' string scope

2023-01-19 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/qtest/migration-test.c | 29 +++-- 1 file changed, 15 insertions(+), 14 deletions(-) diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c index 8beeda4686..6c3db95113 100644 --- a/tests/qtest/migration-te