Re: [PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-12-15 Thread John Snow
On 12/15/20 11:55 AM, Markus Armbruster wrote: John Snow writes: On 11/16/20 3:47 AM, Markus Armbruster wrote: John Snow writes: _make_tree might receive a dict or some other type. Are you talking about @obj? Yes. Recommend to be explict: _make_tree()'s first argument can be ...

Re: [PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-12-15 Thread Markus Armbruster
John Snow writes: > On 11/16/20 3:47 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> _make_tree might receive a dict or some other type. >> >> Are you talking about @obj? >> > > Yes. Recommend to be explict: _make_tree()'s first argument can be ... > It *usually* takes a dict.

Re: [PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-12-07 Thread John Snow
On 11/16/20 3:47 AM, Markus Armbruster wrote: John Snow writes: _make_tree might receive a dict or some other type. Are you talking about @obj? Yes. It *usually* takes a dict. sometimes it doesn't. Adding features information should a

Re: [PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-11-16 Thread Markus Armbruster
John Snow writes: > _make_tree might receive a dict or some other type. Are you talking about @obj? > Adding features > information should arguably be performed by the caller at such a time > when we know the type of the object and don't have

Re: [PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-11-06 Thread Cleber Rosa
On Mon, Oct 26, 2020 at 03:42:46PM -0400, John Snow wrote: > _make_tree might receive a dict or some other type. Adding features > information should arguably be performed by the caller at such a time > when we know the type of the object and don't have to re-interrogate it. > > Signed-off-by: Joh

[PATCH v2 06/11] qapi/introspect.py: add _gen_features helper

2020-10-26 Thread John Snow
_make_tree might receive a dict or some other type. Adding features information should arguably be performed by the caller at such a time when we know the type of the object and don't have to re-interrogate it. Signed-off-by: John Snow --- scripts/qapi/introspect.py | 19 --- 1 f