Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-06-11 Thread Eric Auger
Hi Jonathan On 5/30/25 12:02 PM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:07 +0200 > Eric Auger wrote: > >> acpi_dsdt_add_pci_osc() name is confusing as it gives the impression >> it appends the _OSC method but in fact it also appends the _DSM method >> for the host bridge. Let's split

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-06-11 Thread Eric Auger
Hi Jonathan, On 5/30/25 12:02 PM, Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:07 +0200 > Eric Auger wrote: > >> acpi_dsdt_add_pci_osc() name is confusing as it gives the impression >> it appends the _OSC method but in fact it also appends the _DSM method >> for the host bridge. Let's spli

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-06-02 Thread Igor Mammedov
On Fri, 30 May 2025 16:00:19 +0100 Jonathan Cameron wrote: > On Fri, 30 May 2025 14:05:16 +0200 > Igor Mammedov wrote: > > > On Fri, 30 May 2025 11:02:27 +0100 > > Jonathan Cameron wrote: > > > > > On Tue, 27 May 2025 09:40:07 +0200 > > > Eric Auger wrote: > > > > > > > acpi_dsdt_add_

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-05-30 Thread Jonathan Cameron via
On Fri, 30 May 2025 14:05:16 +0200 Igor Mammedov wrote: > On Fri, 30 May 2025 11:02:27 +0100 > Jonathan Cameron wrote: > > > On Tue, 27 May 2025 09:40:07 +0200 > > Eric Auger wrote: > > > > > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > > > it appends the _OSC meth

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-05-30 Thread Igor Mammedov
On Fri, 30 May 2025 11:02:27 +0100 Jonathan Cameron wrote: > On Tue, 27 May 2025 09:40:07 +0200 > Eric Auger wrote: > > > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > > it appends the _OSC method but in fact it also appends the _DSM method > > for the host bridge. Let'

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-05-30 Thread Jonathan Cameron via
On Tue, 27 May 2025 09:40:07 +0200 Eric Auger wrote: > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > it appends the _OSC method but in fact it also appends the _DSM method > for the host bridge. Let's split the function into two separate ones > and let them return the met

Re: [PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-05-27 Thread Igor Mammedov
On Tue, 27 May 2025 09:40:07 +0200 Eric Auger wrote: > acpi_dsdt_add_pci_osc() name is confusing as it gives the impression > it appends the _OSC method but in fact it also appends the _DSM method > for the host bridge. Let's split the function into two separate ones > and let them return the met

[PATCH v2 05/25] hw/pci-host/gpex-acpi: Split host bridge OSC and DSM generation

2025-05-27 Thread Eric Auger
acpi_dsdt_add_pci_osc() name is confusing as it gives the impression it appends the _OSC method but in fact it also appends the _DSM method for the host bridge. Let's split the function into two separate ones and let them return the method Aml pointer instead. This matches the way it is done on x86