Re: [PATCH v2 05/11] dump/dump: Add section string table support

2022-07-14 Thread Marc-André Lureau
Hi On Thu, Jul 14, 2022 at 3:54 PM Janosch Frank wrote: > On 7/13/22 17:58, Marc-André Lureau wrote: > > Hi > > > > On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank > wrote: > >> > >> Time to add a bit more descriptiveness to the dumps. > > > > Please add some more description & motivation to the

Re: [PATCH v2 05/11] dump/dump: Add section string table support

2022-07-14 Thread Janosch Frank
On 7/13/22 17:58, Marc-André Lureau wrote: Hi On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank wrote: Time to add a bit more descriptiveness to the dumps. Please add some more description & motivation to the patch (supposedly necessary for next patches), and explain that it currently doesn't c

Re: [PATCH v2 05/11] dump/dump: Add section string table support

2022-07-13 Thread Marc-André Lureau
Hi On Wed, Jul 13, 2022 at 5:07 PM Janosch Frank wrote: > > Time to add a bit more descriptiveness to the dumps. Please add some more description & motivation to the patch (supposedly necessary for next patches), and explain that it currently doesn't change the dump (afaict). > > Signed-off-by:

[PATCH v2 05/11] dump/dump: Add section string table support

2022-07-13 Thread Janosch Frank
Time to add a bit more descriptiveness to the dumps. Signed-off-by: Janosch Frank Reviewed-by: Richard Henderson --- dump/dump.c | 106 -- include/sysemu/dump.h | 1 + 2 files changed, 94 insertions(+), 13 deletions(-) diff --git a/dump/dump.