Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-06 Thread John Levon
On Tue, May 06, 2025 at 02:27:21PM +0200, Cédric Le Goater wrote: > !---| > CAUTION: External Email > > |---! > > On 5/6/25 13:38, John Levon wrote: > > On Mon, May 05

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-06 Thread Cédric Le Goater
On 5/6/25 13:38, John Levon wrote: On Mon, May 05, 2025 at 11:19:30AM +0200, Cédric Le Goater wrote: +int vfio_device_get_irq_info(VFIODevice *vbasedev, int index, +struct vfio_irq_info *info); This is breaking the windows build. Sorry, I forgot to set up cro

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-06 Thread John Levon
On Mon, May 05, 2025 at 11:19:30AM +0200, Cédric Le Goater wrote: > > +int vfio_device_get_irq_info(VFIODevice *vbasedev, int index, > > +struct vfio_irq_info *info); > > This is breaking the windows build. Sorry, I forgot to set up cross-compile. I've done so now

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-05 Thread Cédric Le Goater
On 4/30/25 21:39, John Levon wrote: Add a helper similar to vfio_device_get_region_info() and use it everywhere. Replace a couple of needless allocations with stack variables. As a side-effect, this fixes a minor error reporting issue in the call from vfio_msix_early_setup(). Reviewed-by: Cédr

Re: [PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-05-01 Thread Anthony Krowiak
On 4/30/25 3:39 PM, John Levon wrote: Add a helper similar to vfio_device_get_region_info() and use it everywhere. Replace a couple of needless allocations with stack variables. As a side-effect, this fixes a minor error reporting issue in the call from vfio_msix_early_setup(). Reviewed-by

[PATCH v2 04/15] vfio: add vfio_device_get_irq_info() helper

2025-04-30 Thread John Levon
Add a helper similar to vfio_device_get_region_info() and use it everywhere. Replace a couple of needless allocations with stack variables. As a side-effect, this fixes a minor error reporting issue in the call from vfio_msix_early_setup(). Reviewed-by: Cédric Le Goater Signed-off-by: John Levo