Re: [PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

2020-04-28 Thread Daniel P . Berrangé
On Tue, Apr 28, 2020 at 04:03:33PM +0100, Daniel P. Berrangé wrote: > On Sun, Mar 08, 2020 at 05:18:53PM +0200, Maxim Levitsky wrote: > > Some options are only useful for creation > > (or hard to be amended, like cluster size for qcow2), while some other > > options are only useful for amend, like

Re: [PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

2020-04-28 Thread Daniel P . Berrangé
On Sun, Mar 08, 2020 at 05:18:53PM +0200, Maxim Levitsky wrote: > Some options are only useful for creation > (or hard to be amended, like cluster size for qcow2), while some other > options are only useful for amend, like upcoming keyslot management > options for luks > > Since currently only qco

[PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

2020-03-08 Thread Maxim Levitsky
Some options are only useful for creation (or hard to be amended, like cluster size for qcow2), while some other options are only useful for amend, like upcoming keyslot management options for luks Since currently only qcow2 supports amend, move all its options to a common macro and then include i

[PATCH v2 04/14] block/amend: separate amend and create options for qemu-img

2020-01-30 Thread Maxim Levitsky
Some options are only useful for creation (or hard to be amended, like cluster size for qcow2), while some other options are only useful for amend, like upcoming keyslot management options for luks Since currently only qcow2 supports amend, move all its options to a common macro and then include i