Re: [PATCH v2 04/13] contrib/elf2dmp: Conform to the error reporting pattern

2024-03-06 Thread Peter Maydell
On Wed, 6 Mar 2024 at 05:01, Akihiko Odaki wrote: > > On 2024/03/05 22:28, Peter Maydell wrote: > > On Tue, 5 Mar 2024 at 07:36, Akihiko Odaki wrote: > >> @@ -206,7 +206,7 @@ static int fix_dtb(struct va_space *vs, QEMU_Elf *qe) > >> va_space_set_dtb(vs, s->cr[3]); > >>

Re: [PATCH v2 04/13] contrib/elf2dmp: Conform to the error reporting pattern

2024-03-05 Thread Akihiko Odaki
On 2024/03/05 22:28, Peter Maydell wrote: On Tue, 5 Mar 2024 at 07:36, Akihiko Odaki wrote: include/qapi/error.h says: We recommend * bool-valued functions return true on success / false on failure, ... Signed-off-by: Akihiko Odaki --- contrib/elf2dmp/addrspace.h | 6 +-- contrib/elf2

Re: [PATCH v2 04/13] contrib/elf2dmp: Conform to the error reporting pattern

2024-03-05 Thread Peter Maydell
On Tue, 5 Mar 2024 at 07:36, Akihiko Odaki wrote: > > include/qapi/error.h says: > > We recommend > > * bool-valued functions return true on success / false on failure, > > ... > > Signed-off-by: Akihiko Odaki > --- > contrib/elf2dmp/addrspace.h | 6 +-- > contrib/elf2dmp/download.h | 2 +-

[PATCH v2 04/13] contrib/elf2dmp: Conform to the error reporting pattern

2024-03-04 Thread Akihiko Odaki
include/qapi/error.h says: > We recommend > * bool-valued functions return true on success / false on failure, > ... Signed-off-by: Akihiko Odaki --- contrib/elf2dmp/addrspace.h | 6 +-- contrib/elf2dmp/download.h | 2 +- contrib/elf2dmp/pdb.h | 2 +- contrib/elf2dmp/qemu_elf.h |