Re: [PATCH v2 03/24] migration: Normalize tls arguments

2025-07-04 Thread Peter Xu
On Fri, Jul 04, 2025 at 10:12:33AM -0300, Fabiano Rosas wrote: [...] > >>> +static void tls_opt_to_str(StrOrNull **tls_opt) > >>> +{ > >>> +StrOrNull *opt = *tls_opt; > >>> + > >>> +if (!opt) { > >>> +return; > >> > >> ... it can also be null. > >> > > > > Hmm, I'll have to double

Re: [PATCH v2 03/24] migration: Normalize tls arguments

2025-07-04 Thread Fabiano Rosas
Fabiano Rosas writes: > Markus Armbruster writes: > >> Fabiano Rosas writes: >> ... >>> diff --git a/migration/options.c b/migration/options.c >>> index 384ef9e421..f7bbdba5fc 100644 >>> --- a/migration/options.c >>> +++ b/migration/options.c >> >> [...] >> >>> @@ -935,6 +951,37 @@ AnnouncePa

Re: [PATCH v2 03/24] migration: Normalize tls arguments

2025-07-01 Thread Fabiano Rosas
Markus Armbruster writes: > Fabiano Rosas writes: > >> The migration parameters tls_creds, tls_authz and tls_hostname >> currently have a non-uniform handling. When used as arguments to >> migrate-set-parameters, their type is StrOrNull and when used as >> return value from query-migrate-paramet

Re: [PATCH v2 03/24] migration: Normalize tls arguments

2025-07-01 Thread Markus Armbruster
Fabiano Rosas writes: > The migration parameters tls_creds, tls_authz and tls_hostname > currently have a non-uniform handling. When used as arguments to > migrate-set-parameters, their type is StrOrNull and when used as > return value from query-migrate-parameters their type is a plain > string.

[PATCH v2 03/24] migration: Normalize tls arguments

2025-06-30 Thread Fabiano Rosas
The migration parameters tls_creds, tls_authz and tls_hostname currently have a non-uniform handling. When used as arguments to migrate-set-parameters, their type is StrOrNull and when used as return value from query-migrate-parameters their type is a plain string. Not only having to convert betwe