Re: [PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-30 Thread Juan Quintela
Leonardo Bras Soares Passos wrote: > On Fri, May 26, 2023 at 5:04 AM Juan Quintela wrote: >> > Maybe too much? >> >> I dropped this patch for two reasons: >> >> - reviewers gave me a bad time with it O:-) >> - it was there only so if anyone was meassuring that new counters are >> the same that

Re: [PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-26 Thread Leonardo Bras Soares Passos
On Fri, May 26, 2023 at 5:04 AM Juan Quintela wrote: > > Leonardo Brás wrote: > > On Mon, 2023-05-15 at 21:56 +0200, Juan Quintela wrote: > >> We forget several places to add to trasferred amount of data. With > >> this fixes I get: > >> > >>qemu_file_transferred() + multifd_bytes == transfe

Re: [PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-26 Thread Juan Quintela
Leonardo Brás wrote: > On Mon, 2023-05-15 at 21:56 +0200, Juan Quintela wrote: >> We forget several places to add to trasferred amount of data. With >> this fixes I get: >> >>qemu_file_transferred() + multifd_bytes == transferred >> >> The only place whrer this is not true is during devices

Re: [PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-22 Thread Leonardo Brás
On Mon, 2023-05-15 at 21:56 +0200, Juan Quintela wrote: > We forget several places to add to trasferred amount of data. With > this fixes I get: > >qemu_file_transferred() + multifd_bytes == transferred > > The only place whrer this is not true is during devices sending. But > going all thr

Re: [PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-16 Thread David Edmondson
Juan Quintela writes: > We forget several places to add to trasferred amount of data. With "transferred". > this fixes I get: > >qemu_file_transferred() + multifd_bytes == transferred > > The only place whrer this is not true is during devices sending. But "where" > going all through th

[PATCH v2 02/16] migration: Correct transferred bytes value

2023-05-15 Thread Juan Quintela
We forget several places to add to trasferred amount of data. With this fixes I get: qemu_file_transferred() + multifd_bytes == transferred The only place whrer this is not true is during devices sending. But going all through the full tree searching for devices that use QEMUFile directly is