Re: [PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-08 Thread Richard Henderson
On 2/8/21 11:30 AM, Peter Maydell wrote: > On Mon, 8 Feb 2021 at 18:58, Richard Henderson > wrote: >> >> On 2/8/21 10:28 AM, Peter Maydell wrote: >>> On Mon, 8 Feb 2021 at 17:53, Peter Maydell wrote: The AAPCS says that q4-q7 are preserved across calls. >>> >>> Speaking of which, doesn't tha

Re: [PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 18:58, Richard Henderson wrote: > > On 2/8/21 10:28 AM, Peter Maydell wrote: > > On Mon, 8 Feb 2021 at 17:53, Peter Maydell wrote: > >> The AAPCS says that q4-q7 are preserved across calls. > > > > Speaking of which, doesn't that mean we also need to > > save and restore q4-

Re: [PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-08 Thread Richard Henderson
On 2/8/21 10:28 AM, Peter Maydell wrote: > On Mon, 8 Feb 2021 at 17:53, Peter Maydell wrote: >> The AAPCS says that q4-q7 are preserved across calls. > > Speaking of which, doesn't that mean we also need to > save and restore q4-q7 in tcg_target_qemu_prologue() > if we might be generating neon in

Re: [PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 17:53, Peter Maydell wrote: > The AAPCS says that q4-q7 are preserved across calls. Speaking of which, doesn't that mean we also need to save and restore q4-q7 in tcg_target_qemu_prologue() if we might be generating neon insns? (It doesn't look like aarch64's prologue does t

Re: [PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-08 Thread Peter Maydell
On Mon, 8 Feb 2021 at 03:48, Richard Henderson wrote: > > Add registers and function stubs. The functionality > is disabled via use_neon_instructions defined to 0. > > We must still include results for the mandatory opcodes in > tcg_target_op_def, as all opcodes are checked during tcg init. > > S

[PATCH v2 02/15] tcg/arm: Add host vector framework

2021-02-07 Thread Richard Henderson
Add registers and function stubs. The functionality is disabled via use_neon_instructions defined to 0. We must still include results for the mandatory opcodes in tcg_target_op_def, as all opcodes are checked during tcg init. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target-con-set.h |