Re: [PATCH v2 02/12] simpletrace: Annotate magic constants from QEMU code

2023-05-14 Thread Mads Ynddal
> > From my reply to v1 of this patch series: > > This is fragile since this information will be outdated if the C source > code changes (e.g. renaming files or variables). > > Instead I would add the following comment: > > # This is the binary format that the QEMU "simple" trace backend > #

Re: [PATCH v2 02/12] simpletrace: Annotate magic constants from QEMU code

2023-05-09 Thread Stefan Hajnoczi
On Tue, May 02, 2023 at 11:23:29AM +0200, Mads Ynddal wrote: > From: Mads Ynddal > > It wasn't clear where the constants and structs came from, so I added > comments to help. > > Signed-off-by: Mads Ynddal > --- > scripts/simpletrace.py | 14 +++--- > 1 file changed, 7 insertions(+), 7

[PATCH v2 02/12] simpletrace: Annotate magic constants from QEMU code

2023-05-02 Thread Mads Ynddal
From: Mads Ynddal It wasn't clear where the constants and structs came from, so I added comments to help. Signed-off-by: Mads Ynddal --- scripts/simpletrace.py | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/scripts/simpletrace.py b/scripts/simpletrace.py ind