Re: [PATCH v2 02/10] usb/msd: Ensure packet structure layout is correct

2025-04-11 Thread Nicholas Piggin
On Fri Apr 11, 2025 at 8:21 PM AEST, Philippe Mathieu-Daudé wrote: > On 11/4/25 10:04, Nicholas Piggin wrote: >> These structures are hardware interfaces, ensure the layout is >> correct. >> >> Signed-off-by: Nicholas Piggin >> --- >> hw/usb/dev-storage.c | 5 - >> 1 file changed, 4 insert

Re: [PATCH v2 02/10] usb/msd: Ensure packet structure layout is correct

2025-04-11 Thread Philippe Mathieu-Daudé
On 11/4/25 12:21, Philippe Mathieu-Daudé wrote: On 11/4/25 10:04, Nicholas Piggin wrote: These structures are hardware interfaces, ensure the layout is correct. Signed-off-by: Nicholas Piggin ---   hw/usb/dev-storage.c | 5 -   1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw

Re: [PATCH v2 02/10] usb/msd: Ensure packet structure layout is correct

2025-04-11 Thread Philippe Mathieu-Daudé
On 11/4/25 10:04, Nicholas Piggin wrote: These structures are hardware interfaces, ensure the layout is correct. Signed-off-by: Nicholas Piggin --- hw/usb/dev-storage.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 2

Re: [PATCH v2 02/10] usb/msd: Ensure packet structure layout is correct

2025-04-11 Thread Philippe Mathieu-Daudé
On 11/4/25 10:04, Nicholas Piggin wrote: These structures are hardware interfaces, ensure the layout is correct. Signed-off-by: Nicholas Piggin --- hw/usb/dev-storage.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé

[PATCH v2 02/10] usb/msd: Ensure packet structure layout is correct

2025-04-11 Thread Nicholas Piggin
These structures are hardware interfaces, ensure the layout is correct. Signed-off-by: Nicholas Piggin --- hw/usb/dev-storage.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-storage.c b/hw/usb/dev-storage.c index 2d7306b0572..87c22476f6b 100644 --- a/hw/usb/d