Re: [PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-03-01 Thread Volker Rümelin
Am 26.01.22 um 09:48 schrieb Gerd Hoffmann: Hi, --- a/audio/audio_int.h +++ b/audio/audio_int.h @@ -266,6 +266,12 @@ static inline size_t audio_ring_dist(size_t dst, size_t src, size_t len) return (dst >= src) ? (dst - src) : (len - src + dst); } You haven't touched this function

Re: [PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-01-26 Thread Christian Schoenebeck
On Dienstag, 25. Januar 2022 19:57:59 CET Volker Rümelin wrote: > > On Samstag, 22. Januar 2022 13:57:31 CET Volker Rümelin wrote: > >> Replace open-coded buffer arithmetic with the new function > >> audio_ring_posb(). That's the position in backward direction > >> of a given point at a given dista

Re: [PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-01-26 Thread Gerd Hoffmann
Hi, > > > --- a/audio/audio_int.h > > > +++ b/audio/audio_int.h > > > @@ -266,6 +266,12 @@ static inline size_t audio_ring_dist(size_t dst, > > > size_t src, size_t len) > > > return (dst >= src) ? (dst - src) : (len - src + dst); > > > } > > You haven't touched this function, but while

Re: [PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-01-25 Thread Volker Rümelin
On Samstag, 22. Januar 2022 13:57:31 CET Volker Rümelin wrote: Replace open-coded buffer arithmetic with the new function audio_ring_posb(). That's the position in backward direction of a given point at a given distance. Signed-off-by: Volker Rümelin --- First of all, getting rid of all those r

Re: [PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-01-23 Thread Christian Schoenebeck
On Samstag, 22. Januar 2022 13:57:31 CET Volker Rümelin wrote: > Replace open-coded buffer arithmetic with the new function > audio_ring_posb(). That's the position in backward direction > of a given point at a given distance. > > Signed-off-by: Volker Rümelin > --- First of all, getting rid of

[PATCH v2 01/15] audio: replace open-coded buffer arithmetic

2022-01-22 Thread Volker Rümelin
Replace open-coded buffer arithmetic with the new function audio_ring_posb(). That's the position in backward direction of a given point at a given distance. Signed-off-by: Volker Rümelin --- audio/audio.c | 25 +++-- audio/audio_int.h | 6 ++ audio/coreaudio.c | 10