Re: [PATCH v2 00/53] migration/rdma: Error handling fixes

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> Markus Armbruster wrote: >>> Oh dear, where to start. There's so much wrong, and in pretty obvious >>> ways. This code should never have passed review. I'm refraining from >>> saying more; see the commit messages instead. >>> >>> Issues re

Re: [PATCH v2 00/53] migration/rdma: Error handling fixes

2023-10-04 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Oh dear, where to start. There's so much wrong, and in pretty obvious >> ways. This code should never have passed review. I'm refraining from >> saying more; see the commit messages instead. >> >> Issues remaining after this series include:

Re: [PATCH v2 00/53] migration/rdma: Error handling fixes

2023-10-04 Thread Juan Quintela
Markus Armbruster wrote: > Oh dear, where to start. There's so much wrong, and in pretty obvious > ways. This code should never have passed review. I'm refraining from > saying more; see the commit messages instead. > > Issues remaining after this series include: > > * Terrible error messages >

[PATCH v2 00/53] migration/rdma: Error handling fixes

2023-09-28 Thread Markus Armbruster
Oh dear, where to start. There's so much wrong, and in pretty obvious ways. This code should never have passed review. I'm refraining from saying more; see the commit messages instead. Issues remaining after this series include: * Terrible error messages * Some error message cascades remain