Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-10 Thread Paolo Bonzini
On 8/6/22 17:32, Vladimir Sementsov-Ogievskiy wrote: if I understand correctly you suggest: .prepare = check and then change aiocontext .abort = revert aiocontext change .commit = nothing Yes. And that's is how it used actually now in transactions, for example:   bdrv_attach_child_common (whi

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-06 Thread Vladimir Sementsov-Ogievskiy
On 8/5/22 17:57, Emanuele Giuseppe Esposito wrote: Am 05/08/2022 um 16:35 schrieb Vladimir Sementsov-Ogievskiy: On 8/5/22 16:22, Emanuele Giuseppe Esposito wrote: Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of th

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-05 Thread Emanuele Giuseppe Esposito
Am 05/08/2022 um 16:35 schrieb Vladimir Sementsov-Ogievskiy: > On 8/5/22 16:22, Emanuele Giuseppe Esposito wrote: >> >> >> Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: >>> On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of this series is to reorganize bdrv_try_se

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-05 Thread Vladimir Sementsov-Ogievskiy
On 8/5/22 16:36, Emanuele Giuseppe Esposito wrote: Am 05/08/2022 um 15:22 schrieb Emanuele Giuseppe Esposito: Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of this series is to reorganize bdrv_try_set_aio_context an

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-05 Thread Vladimir Sementsov-Ogievskiy
On 8/5/22 16:22, Emanuele Giuseppe Esposito wrote: Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of this series is to reorganize bdrv_try_set_aio_context and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks i

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-05 Thread Emanuele Giuseppe Esposito
Am 05/08/2022 um 15:22 schrieb Emanuele Giuseppe Esposito: > > > Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: >> On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: >>> The aim of this series is to reorganize bdrv_try_set_aio_context >>> and drop BDS ->set_aio_context and ->can

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-08-05 Thread Emanuele Giuseppe Esposito
Am 27/07/2022 um 18:13 schrieb Vladimir Sementsov-Ogievskiy: > On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: >> The aim of this series is to reorganize bdrv_try_set_aio_context >> and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in >> favour of a new one, ->change_aio_ctx. >>

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-07-27 Thread Vladimir Sementsov-Ogievskiy
On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of this series is to reorganize bdrv_try_set_aio_context and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in favour of a new one, ->change_aio_ctx. More informations in patch 3 (which is also RFC, due to the doubts I have

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-07-26 Thread Emanuele Giuseppe Esposito
Am 26/07/2022 um 16:24 schrieb Vladimir Sementsov-Ogievskiy: > On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: >> The aim of this series is to reorganize bdrv_try_set_aio_context >> and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in >> favour of a new one, ->change_aio_ctx. >>

Re: [PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-07-26 Thread Vladimir Sementsov-Ogievskiy
On 7/25/22 15:21, Emanuele Giuseppe Esposito wrote: The aim of this series is to reorganize bdrv_try_set_aio_context and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in favour of a new one, ->change_aio_ctx. More informations in patch 3 (which is also RFC, due to the doubts patch

[PATCH v2 00/11] Refactor bdrv_try_set_aio_context using transactions

2022-07-25 Thread Emanuele Giuseppe Esposito
The aim of this series is to reorganize bdrv_try_set_aio_context and drop BDS ->set_aio_context and ->can_set_aio_ctx callbacks in favour of a new one, ->change_aio_ctx. More informations in patch 3 (which is also RFC, due to the doubts I have with AioContext locks). Patch 1 just add assertions i