Re: [PATCH v2 0/3] block: drop BlockDriverState::read_only

2021-05-31 Thread Kevin Wolf
Am 27.05.2021 um 17:40 hat Vladimir Sementsov-Ogievskiy geschrieben: > Hi all! > > The field duplicates information in .open_flags. We have to carefully > sync these two fields everywhere. It's simple to introduce a bug by > forgetting it. > > Let's drop the field, and fix users to call bdrv_is_r

[PATCH v2 0/3] block: drop BlockDriverState::read_only

2021-05-27 Thread Vladimir Sementsov-Ogievskiy
Hi all! The field duplicates information in .open_flags. We have to carefully sync these two fields everywhere. It's simple to introduce a bug by forgetting it. Let's drop the field, and fix users to call bdrv_is_read_only() and bdrv_is_writable() instead. v2: 01: write "update_header =\n..." in