On 5/15/20 1:36 AM, Raphael Pour wrote:
From e5749541494abcdcaa37d752172741e1bc38e984 Mon Sep 17 00:00:00 2001
From: Raphael Pour
Date: Fri, 15 May 2020 08:30:50 +0200
Subject: [PATCH] qemu-nbd: Close inherited stderr
Close inherited stderr of the parent if fork_process is false.
Otherwise no
On 5/14/20 4:55 PM, Eric Blake wrote:
> On 5/14/20 9:29 AM, Eric Blake wrote:
>
>>> WARNING: Block comments use a leading /* on a separate line
>>> #20: FILE: qemu-nbd.c:919:
>>> + /* Remember parents stderr only if the fork option is set.
>>>
>
>> The comment could use some grammar he
On 5/14/20 9:29 AM, Eric Blake wrote:
WARNING: Block comments use a leading /* on a separate line
#20: FILE: qemu-nbd.c:919:
+ /* Remember parents stderr only if the fork option is set.
The comment could use some grammar help (s/parents/parent's/), and in
truth, I don't think it a
...@hetzner.com
Subject: [PATCH v2 0/1] qemu-nbd: Close inherited stderr
Type: series
=== OUTPUT BEGIN ===
WARNING: Block comments use a leading /* on a separate line
#20: FILE: qemu-nbd.c:919:
+/* Remember parents stderr only if the fork option is set.
ERROR: suspect code indent for
Patchew URL:
https://patchew.org/QEMU/20200514063112.1457125-1-raphael.p...@hetzner.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20200514063112.1457125-1-raphael.p...@hetzner.com
Subject: [PATCH v2 0/1] qemu-nbd: Close
[...] introduced with e6df58a5, stderr won't get closed if the fork
option is __not__ set.
On 5/14/20 8:31 AM, Raphael Pour wrote:
> introduced with e6df58a5, stderr won't get closed if the fork option is
> set.
--
Hetzner Online GmbH
Am Datacenter-Park 1
08223 Falkenstein/Vogtland
raphael.p...@
Hello,
introduced with e6df58a5, stderr won't get closed if the fork option is
set. This causes other processes reading stderr to block infinietly or
crash while relying on EOF.
v2:
- Instead of closing the inherited stderr in the child, avoid the dup
in the parent if the fork option is no
