Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-27 Thread Konstantin Shkolnyy
On 2/27/2025 00:33, Michael Tokarev wrote: 25.02.2025 15:39, Konstantin Shkolnyy wrote: On 2/25/2025 03:30, Michael Tokarev wrote: This looks like a qemu-stable material. Please let me know if it is not. It won't help without my other "[PATCH v2] vdpa: Allow vDPA to work on big-endian mach

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-26 Thread Michael Tokarev
25.02.2025 15:39, Konstantin Shkolnyy wrote: On 2/25/2025 03:30, Michael Tokarev wrote: This looks like a qemu-stable material. Please let me know if it is not. It won't help without my other "[PATCH v2] vdpa: Allow vDPA to work on big-endian machine". With both patches, VDPA works on a big

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-25 Thread Konstantin Shkolnyy
On 2/25/2025 03:30, Michael Tokarev wrote: 12.02.2025 19:49, Konstantin Shkolnyy wrote: VDPA didn't work on a big-endian machine due to missing/incorrect CPU<->LE data format conversions. Signed-off-by: Konstantin Shkolnyy This looks like a qemu-stable material. Please let me know if it is n

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-25 Thread Michael Tokarev
12.02.2025 19:49, Konstantin Shkolnyy wrote: VDPA didn't work on a big-endian machine due to missing/incorrect CPU<->LE data format conversions. Signed-off-by: Konstantin Shkolnyy This looks like a qemu-stable material. Please let me know if it is not. Thanks, /mjt

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-15 Thread Lei Yang
On Fri, Feb 14, 2025 at 9:02 PM Konstantin Shkolnyy wrote: > > On 2/13/2025 20:24, Lei Yang wrote: > > I tested this patch with vdpa's regression tests, everything works fine. > > > > Tested-by: Lei Yang > > Could you point me to those tests? Sure, the test scenarios include ping, mq tests under

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-14 Thread Konstantin Shkolnyy
On 2/13/2025 20:24, Lei Yang wrote: vdpa's regression tests

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-14 Thread Konstantin Shkolnyy
On 2/13/2025 20:24, Lei Yang wrote: I tested this patch with vdpa's regression tests, everything works fine. Tested-by: Lei Yang Could you point me to those tests?

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-13 Thread Lei Yang
I tested this patch with vdpa's regression tests, everything works fine. Tested-by: Lei Yang On Thu, Feb 13, 2025 at 2:51 PM Eugenio Perez Martin wrote: > > On Wed, Feb 12, 2025 at 5:49 PM Konstantin Shkolnyy > wrote: > > > > VDPA didn't work on a big-endian machine due to missing/incorrect >

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-13 Thread Philippe Mathieu-Daudé
On 13/2/25 07:43, Eugenio Perez Martin wrote: On Wed, Feb 12, 2025 at 7:11 PM Philippe Mathieu-Daudé wrote: On 12/2/25 17:49, Konstantin Shkolnyy wrote: VDPA didn't work on a big-endian machine due to missing/incorrect CPU<->LE data format conversions. Signed-off-by: Konstantin Shkolnyy ---

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Eugenio Perez Martin
On Wed, Feb 12, 2025 at 5:49 PM Konstantin Shkolnyy wrote: > > VDPA didn't work on a big-endian machine due to missing/incorrect > CPU<->LE data format conversions. > Fixes: 10857ec0ad ("vhost: Add VhostShadowVirtqueue") > Signed-off-by: Konstantin Shkolnyy Acked-by: Eugenio Pérez Thanks! >

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Eugenio Perez Martin
On Wed, Feb 12, 2025 at 7:11 PM Philippe Mathieu-Daudé wrote: > > On 12/2/25 17:49, Konstantin Shkolnyy wrote: > > VDPA didn't work on a big-endian machine due to missing/incorrect > > CPU<->LE data format conversions. > > > > Signed-off-by: Konstantin Shkolnyy > > --- > > Changes in v2: Change d

Re: [PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Philippe Mathieu-Daudé
On 12/2/25 17:49, Konstantin Shkolnyy wrote: VDPA didn't work on a big-endian machine due to missing/incorrect CPU<->LE data format conversions. Signed-off-by: Konstantin Shkolnyy --- Changes in v2: Change desc_next[] from LE format to "CPU". hw/virtio/vhost-shadow-virtqueue.c | 18 +

[PATCH v2] vdpa: Fix endian bugs in shadow virtqueue

2025-02-12 Thread Konstantin Shkolnyy
VDPA didn't work on a big-endian machine due to missing/incorrect CPU<->LE data format conversions. Signed-off-by: Konstantin Shkolnyy --- Changes in v2: Change desc_next[] from LE format to "CPU". hw/virtio/vhost-shadow-virtqueue.c | 18 ++ 1 file changed, 10 insertions(+), 8 d