Re: [PATCH v2] util: fix fd leak in qemu_write_pidfile()

On Mon, May 10, 2021 at 04:07:51PM +0100, Peter Maydell wrote: > On Mon, 10 May 2021 at 15:15, Jie Wang wrote: > > > > if execute qemu_open success, have no branch to free the fd, > > so unlink it inadvance, let it free by process exit. > > > > Signed-off-by: Jie Wang > > --- > > util/oslib-posi

Re: [PATCH v2] util: fix fd leak in qemu_write_pidfile()

On Mon, 10 May 2021 at 15:15, Jie Wang wrote: > > if execute qemu_open success, have no branch to free the fd, > so unlink it inadvance, let it free by process exit. > > Signed-off-by: Jie Wang > --- > util/oslib-posix.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/util/oslib-posix.c

[PATCH v2] util: fix fd leak in qemu_write_pidfile()

if execute qemu_open success, have no branch to free the fd, so unlink it inadvance, let it free by process exit. Signed-off-by: Jie Wang --- util/oslib-posix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/oslib-posix.c b/util/oslib-posix.c index 36820fec16..fa881f2ee8 100644 --- a/u