Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-07 Thread Markus Armbruster
Thomas Huth writes: > On 07/07/2020 07.35, Markus Armbruster wrote: >> Richard Henderson writes: >> >>> On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: Coverity noticed commit 950c4e6c94 introduced a dereference before null check in get_opt_value (CID1391003): In get_op

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-07 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 7/7/20 7:48 AM, Markus Armbruster wrote: >> Philippe Mathieu-Daudé writes: >> >>> Coverity noticed commit 950c4e6c94 introduced a dereference before >>> null check in get_opt_value (CID1391003): >>> >>> In get_opt_value: All paths that lead to this null poi

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-07 Thread Daniel P . Berrangé
On Tue, Jul 07, 2020 at 04:14:40AM +0200, Philippe Mathieu-Daudé wrote: > On 7/7/20 3:14 AM, Richard Henderson wrote: > > On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: > >> Coverity noticed commit 950c4e6c94 introduced a dereference before > >> null check in get_opt_value (CID1391003): > >> >

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Philippe Mathieu-Daudé
On 7/7/20 7:48 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Coverity noticed commit 950c4e6c94 introduced a dereference before >> null check in get_opt_value (CID1391003): >> >> In get_opt_value: All paths that lead to this null pointer >> comparison already dereference

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Coverity noticed commit 950c4e6c94 introduced a dereference before > null check in get_opt_value (CID1391003): > > In get_opt_value: All paths that lead to this null pointer > comparison already dereference the pointer earlier (CWE-476) > > We fixed this in co

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Thomas Huth
On 07/07/2020 07.35, Markus Armbruster wrote: > Richard Henderson writes: > >> On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: >>> Coverity noticed commit 950c4e6c94 introduced a dereference before >>> null check in get_opt_value (CID1391003): >>> >>> In get_opt_value: All paths that lead to

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Markus Armbruster
Richard Henderson writes: > On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: >> Coverity noticed commit 950c4e6c94 introduced a dereference before >> null check in get_opt_value (CID1391003): >> >> In get_opt_value: All paths that lead to this null pointer >> comparison already dereference

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Philippe Mathieu-Daudé
On 7/7/20 3:14 AM, Richard Henderson wrote: > On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: >> Coverity noticed commit 950c4e6c94 introduced a dereference before >> null check in get_opt_value (CID1391003): >> >> In get_opt_value: All paths that lead to this null pointer >> comparison alre

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Richard Henderson
On 6/29/20 12:08 AM, Philippe Mathieu-Daudé wrote: > Coverity noticed commit 950c4e6c94 introduced a dereference before > null check in get_opt_value (CID1391003): > > In get_opt_value: All paths that lead to this null pointer > comparison already dereference the pointer earlier (CWE-476) > >

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-06 Thread Laurent Vivier
Le 29/06/2020 à 09:08, Philippe Mathieu-Daudé a écrit : > Coverity noticed commit 950c4e6c94 introduced a dereference before > null check in get_opt_value (CID1391003): > > In get_opt_value: All paths that lead to this null pointer > comparison already dereference the pointer earlier (CWE-476)

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-07-04 Thread Philippe Mathieu-Daudé
Cc'ing qemu-trivial. On 6/29/20 9:08 AM, Philippe Mathieu-Daudé wrote: > Coverity noticed commit 950c4e6c94 introduced a dereference before > null check in get_opt_value (CID1391003): > > In get_opt_value: All paths that lead to this null pointer > comparison already dereference the pointer e

Re: [PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-06-29 Thread Daniel P . Berrangé
On Mon, Jun 29, 2020 at 09:08:58AM +0200, Philippe Mathieu-Daudé wrote: > Coverity noticed commit 950c4e6c94 introduced a dereference before > null check in get_opt_value (CID1391003): > > In get_opt_value: All paths that lead to this null pointer > comparison already dereference the pointer e

[PATCH v2] util/qemu-option: Document the get_opt_value() function

2020-06-29 Thread Philippe Mathieu-Daudé
Coverity noticed commit 950c4e6c94 introduced a dereference before null check in get_opt_value (CID1391003): In get_opt_value: All paths that lead to this null pointer comparison already dereference the pointer earlier (CWE-476) We fixed this in commit 6e3ad3f0e31, but relaxed the check in co