Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-12-13 Thread Richard Henderson
On 12/12/22 22:55, Guenter Roeck wrote: Do you plan to send a formal patch, or do you want me to do it ? I can send a patch. r~

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-12-12 Thread Guenter Roeck
On Mon, Dec 12, 2022 at 08:30:42AM -0600, Richard Henderson wrote: > On 12/11/22 19:13, Guenter Roeck wrote: > > On Sat, Dec 10, 2022 at 07:27:46AM -0800, Guenter Roeck wrote: > > > Hi, > > > > > > On Thu, Sep 01, 2022 at 11:15:09AM +0100, Richard Henderson wrote: > > > > The value previously chos

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-12-12 Thread Guenter Roeck
On 12/12/22 06:30, Richard Henderson wrote: On 12/11/22 19:13, Guenter Roeck wrote: On Sat, Dec 10, 2022 at 07:27:46AM -0800, Guenter Roeck wrote: Hi, On Thu, Sep 01, 2022 at 11:15:09AM +0100, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. Rename all DELAY_SLOT_* an

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-12-12 Thread Richard Henderson
On 12/11/22 19:13, Guenter Roeck wrote: On Sat, Dec 10, 2022 at 07:27:46AM -0800, Guenter Roeck wrote: Hi, On Thu, Sep 01, 2022 at 11:15:09AM +0100, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. Rename all DELAY_SLOT_* and GUSA_* defines to emphasize that they are i

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-12-11 Thread Guenter Roeck
On Sat, Dec 10, 2022 at 07:27:46AM -0800, Guenter Roeck wrote: > Hi, > > On Thu, Sep 01, 2022 at 11:15:09AM +0100, Richard Henderson wrote: > > The value previously chosen overlaps GUSA_MASK. > > > > Rename all DELAY_SLOT_* and GUSA_* defines to emphasize > > that they are included in TB_FLAGs.

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-12-10 Thread Guenter Roeck
Hi, On Thu, Sep 01, 2022 at 11:15:09AM +0100, Richard Henderson wrote: > The value previously chosen overlaps GUSA_MASK. > > Rename all DELAY_SLOT_* and GUSA_* defines to emphasize > that they are included in TB_FLAGs. Add aliases for the > FPSCR and SR bits that are included in TB_FLAGS, so tha

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-10-04 Thread Richard Henderson
On 10/3/22 22:56, Yoshinori Sato wrote: On Mon, 03 Oct 2022 02:23:51 +0900, Richard Henderson wrote: Ping, or should I create a PR myself? r~ Sorry. I can't work this week, so please submit a PR. Ok, I will fold this into the tcg-next PR that I am preparing now. r~

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-10-03 Thread Yoshinori Sato
On Mon, 03 Oct 2022 02:23:51 +0900, Richard Henderson wrote: > > Ping, or should I create a PR myself? > > r~ Sorry. I can't work this week, so please submit a PR. > > On 9/1/22 07:15, Yoshinori Sato wrote: > > On Thu, 01 Sep 2022 19:15:09 +0900, > > Richard Henderson wrote: > >> > >> The val

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-10-02 Thread Richard Henderson
Ping, or should I create a PR myself? r~ On 9/1/22 07:15, Yoshinori Sato wrote: On Thu, 01 Sep 2022 19:15:09 +0900, Richard Henderson wrote: The value previously chosen overlaps GUSA_MASK. Rename all DELAY_SLOT_* and GUSA_* defines to emphasize that they are included in TB_FLAGs. Add aliase

Re: [PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-09-01 Thread Yoshinori Sato
On Thu, 01 Sep 2022 19:15:09 +0900, Richard Henderson wrote: > > The value previously chosen overlaps GUSA_MASK. > > Rename all DELAY_SLOT_* and GUSA_* defines to emphasize > that they are included in TB_FLAGs. Add aliases for the > FPSCR and SR bits that are included in TB_FLAGS, so that > we d

[PATCH v2] target/sh4: Fix TB_FLAG_UNALIGN

2022-09-01 Thread Richard Henderson
The value previously chosen overlaps GUSA_MASK. Rename all DELAY_SLOT_* and GUSA_* defines to emphasize that they are included in TB_FLAGs. Add aliases for the FPSCR and SR bits that are included in TB_FLAGS, so that we don't accidentally reassign those bits. Fixes: 4da06fb3062 ("target/sh4: Imp