Re: [PATCH v2] target/arm: Add overflow check for gt_recalc_timer

2023-11-20 Thread Peter Maydell
On Thu, 9 Nov 2023 at 15:14, Leonid Komarianskyi wrote: > > Peter Maydell, thank you for your comments. > I apologize for so late response - returned to this issue and now I will > answer faster. I fixed the commit according to your recommendations, > please take a look at the new version. > > >

[PATCH v2] target/arm: Add overflow check for gt_recalc_timer

2023-11-09 Thread Leonid Komarianskyi
If gt_timer is enabled before cval initialization on a virtualized setup on QEMU, cval equals (UINT64_MAX - 1). Adding an offset value to this causes an overflow that sets timer into the past, which leads to infinite loop, because this timer fires immediately and calls gt_recalc_timer() once more,

Re: [PATCH v2] target/arm: Add overflow check for gt_recalc_timer

2023-11-09 Thread Leonid Komarianskyi
Peter Maydell, thank you for your comments. I apologize for so late response - returned to this issue and now I will answer faster. I fixed the commit according to your recommendations, please take a look at the new version. > There is also a comment or two from me in the bug report pointing >