Re: Ping: Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-08-03 Thread David Hildenbrand
On 03.08.23 17:43, ThinerLogoer wrote: At 2023-07-28 18:45:20, "David Hildenbrand" wrote: Whatever you prefer! If I resend the patch, I would keep you the author and only add my Co-authored-by: Signed-off-by:. Just let me know. Hello, I wonder whether you have planned to resubmit the cur

Ping: Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-08-03 Thread ThinerLogoer
At 2023-07-28 18:45:20, "David Hildenbrand" wrote: > > >Whatever you prefer! If I resend the patch, I would keep you the author >and only add my Co-authored-by: Signed-off-by:. > >Just let me know. > Hello, I wonder whether you have planned to resubmit the current patch anytime soon, or is it

Re:Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-28 Thread ThinerLogoer
At 2023-07-28 18:45:20, "David Hildenbrand" wrote: >>> Quick untested attempt to move retry handling to the caller: >>> >>> diff --git a/softmmu/physmem.c b/softmmu/physmem.c >>> index 3df73542e1..c826bb78fc 100644 >>> --- a/softmmu/physmem.c >>> +++ b/softmmu/physmem.c >>> @@ -1289,8 +1289,7 @@ s

Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-28 Thread David Hildenbrand
On 28.07.23 07:46, ThinerLogoer wrote: Sorry my mail agent just have a bug No worries :) At 2023-07-28 02:30:09, "David Hildenbrand" wrote: On 27.07.23 17:20, ThinerLogoer wrote: At 2023-07-27 21:18:44, "David Hildenbrand" wrote: On 26.07.23 16:59, Thiner Logoer wrote: Users may give

Re:Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-27 Thread ThinerLogoer
Sorry my mail agent just have a bug At 2023-07-28 02:30:09, "David Hildenbrand" wrote: >On 27.07.23 17:20, ThinerLogoer wrote: >> >> At 2023-07-27 21:18:44, "David Hildenbrand" wrote: >>> On 26.07.23 16:59, Thiner Logoer wrote: Users may give "-mem-path" a read only file and expect the fil

Re:Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-27 Thread ThinerLogoer
At 2023-07-28 02:30:09, "David Hildenbrand" wrote: >On 27.07.23 17:20, ThinerLogoer wrote: >> >> At 2023-07-27 21:18:44, "David Hildenbrand" wrote: >>> On 26.07.23 16:59, Thiner Logoer wrote: Users may give "-mem-path" a read only file and expect the file to be mapped r

Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-27 Thread David Hildenbrand
On 27.07.23 17:20, ThinerLogoer wrote: At 2023-07-27 21:18:44, "David Hildenbrand" wrote: On 26.07.23 16:59, Thiner Logoer wrote: Users may give "-mem-path" a read only file and expect the file to be mapped read-write privately. Allow this but give a warning since other users may surprise whe

Re:Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-27 Thread ThinerLogoer
At 2023-07-27 21:18:44, "David Hildenbrand" wrote: >On 26.07.23 16:59, Thiner Logoer wrote: >> Users may give "-mem-path" a read only file and expect the file >> to be mapped read-write privately. Allow this but give a warning >> since other users may surprise when the ram file is readonly and >>

Re: [PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-27 Thread David Hildenbrand
On 26.07.23 16:59, Thiner Logoer wrote: Users may give "-mem-path" a read only file and expect the file to be mapped read-write privately. Allow this but give a warning since other users may surprise when the ram file is readonly and qemu suddenly aborts elsewhere. Suggested-by: David Hildenbran

[PATCH v2] softmmu/physmem: try opening file readonly before failure in file_ram_open

2023-07-26 Thread Thiner Logoer
Users may give "-mem-path" a read only file and expect the file to be mapped read-write privately. Allow this but give a warning since other users may surprise when the ram file is readonly and qemu suddenly aborts elsewhere. Suggested-by: David Hildenbrand Signed-off-by: Thiner Logoer --- See