On 4/4/24 06:26, Zack Buhman wrote:
The saturation arithmetic logic in helper_macl is not correct.
I tested and verified this behavior on a SH7091, the general pattern
is a code sequence such as:
sets
mov.l _mach,r2
lds r2,mach
mov.l _macl,r2
lds r2,macl
Signed-off-by: Zack Buhman
- Original message -
From: "Philippe Mathieu-Daudé"
To: Peter Maydell , Zack Buhman
Cc: qemu-devel@nongnu.org, Yoshinori Sato
Subject: Re: [PATCH v2] sh4: mac.l: implement saturation arithmetic logic
Date: Friday, April 05, 2024 1:26 AM
Hi Zack,
Hi Zack,
Cc'ing the maintainer of this file, Yoshinori:
$ ./scripts/get_maintainer.pl -f target/sh4/op_helper.c
Yoshinori Sato (reviewer:SH4 TCG CPUs)
(https://www.qemu.org/docs/master/devel/submitting-a-patch.html#cc-the-relevant-maintainer)
On 4/4/24 18:39, Peter Maydell wrote:
On Thu, 4 Ap
On Thu, 4 Apr 2024 at 17:26, Zack Buhman wrote:
>
> The saturation arithmetic logic in helper_macl is not correct.
>
> I tested and verified this behavior on a SH7091, the general pattern
> is a code sequence such as:
>
> sets
>
> mov.l _mach,r2
> lds r2,mach
> mov.
The saturation arithmetic logic in helper_macl is not correct.
I tested and verified this behavior on a SH7091, the general pattern
is a code sequence such as:
sets
mov.l _mach,r2
lds r2,mach
mov.l _macl,r2
lds r2,macl
mova _n,r0
mov r0,r1
