Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-06 Thread Paolo Bonzini
On 05/10/20 21:22, Peter Maydell wrote: >> +def main(args): >> +if len(args) <= 3: >> +sys.exit(0) >> + >> +dir = args[1] >> +pkgversion = args[2] >> +version = args[3] In addition to what Peter pointed out, all these lines can be changed to def main(dir, pkgversion, v

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 3:23 AM Peter Maydell wrote: > > On Mon, 5 Oct 2020 at 18:24, Yonggang Luo wrote: > > > > The sh script are harder to maintain for compatible different > > xsh environment > > > > Signed-off-by: Yonggang Luo > > --- > > meson.build | 2 +- > > scripts/qemu-ve

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Peter Maydell
On Mon, 5 Oct 2020 at 18:24, Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > xsh environment > > Signed-off-by: Yonggang Luo > --- > meson.build | 2 +- > scripts/qemu-version.py | 30 ++ > scripts/qemu-version.sh |

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
On Tue, Oct 6, 2020 at 2:10 AM Philippe Mathieu-Daudé wrote: > > On 10/5/20 7:21 PM, Yonggang Luo wrote: > > The sh script are harder to maintain for compatible different > > xsh environment > > > > Signed-off-by: Yonggang Luo > > --- > > What are the changes since v1? +pc = subprocess.run([

Re: [PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Philippe Mathieu-Daudé
On 10/5/20 7:21 PM, Yonggang Luo wrote: > The sh script are harder to maintain for compatible different > xsh environment > > Signed-off-by: Yonggang Luo > --- What are the changes since v1? > meson.build | 2 +- > scripts/qemu-version.py | 30 ++ > scr

[PATCH v2] scripts: Convert qemu-version.sh to qemu-version.py

2020-10-05 Thread Yonggang Luo
The sh script are harder to maintain for compatible different xsh environment Signed-off-by: Yonggang Luo --- meson.build | 2 +- scripts/qemu-version.py | 30 ++ scripts/qemu-version.sh | 25 - 3 files changed, 31 insertions(+), 2