Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On 30/1/24 16:11, Alex Bennée wrote: Manos Pitsidianakis writes: On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote: On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: Check if a file argument is a cover letter patch produced by git-format-patch --cover-letter; It is in

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

Manos Pitsidianakis writes: > On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote: >>On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: >>> Check if a file argument is a cover letter patch produced by >>> git-format-patch --cover-letter; It is initialized with subject suffix

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 15:11, Alex Bennée wrote: > I suspect the problem is that checkpatch.pl is an import from the Linux > source tree which has since had syncs with its upstream as well as a > slew of QEMU specific patches. If we don't care about tracking upstream > anymore we could bite the bu

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On 30/1/24 12:30, Peter Maydell wrote: On Tue, 30 Jan 2024 at 11:24, Philippe Mathieu-Daudé wrote: Hi Manos, On 30/1/24 12:02, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote: On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 1

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 11:24, Philippe Mathieu-Daudé wrote: > > Hi Manos, > > On 30/1/24 12:02, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:57, Peter Maydell > > wrote: > >> > >> On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis > >> wrote: > >>> > >>> On Tue, 30 Jan 2024 at 12:42,

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

Hi Manos, On 30/1/24 12:02, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote: On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis wrote: On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote: On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis wrote: On Tue, 30 Ja

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 12:57, Peter Maydell wrote: > > On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis > wrote: > > > > On Tue, 30 Jan 2024 at 12:42, Peter Maydell > > wrote: > > > > > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > > > wrote: > > > > > > > > On Tue, 30 Jan 2024 at 12:

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 10:51, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote: > > > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > > wrote: > > > > > > On Tue, 30 Jan 2024 at 12:34, Peter Maydell > > > wrote: > > > > > > > > On Tue, 30 Jan 2024 at 10:11

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 12:42, Peter Maydell wrote: > > On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis > wrote: > > > > On Tue, 30 Jan 2024 at 12:34, Peter Maydell > > wrote: > > > > > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > > > wrote: > > > > > > > > Check if a file argument i

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 10:39, Manos Pitsidianakis wrote: > > On Tue, 30 Jan 2024 at 12:34, Peter Maydell wrote: > > > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > > wrote: > > > > > > Check if a file argument is a cover letter patch produced by > > > git-format-patch --cover-letter; It

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 12:34, Peter Maydell wrote: > > On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis > wrote: > > > > Check if a file argument is a cover letter patch produced by > > git-format-patch --cover-letter; It is initialized with subject suffix " > > *** SUBJECT HERE ***" and body pr

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 at 10:11, Manos Pitsidianakis wrote: > > Check if a file argument is a cover letter patch produced by > git-format-patch --cover-letter; It is initialized with subject suffix " > *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they > exist, warn the user. FWIW,

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote: On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: Check if a file argument is a cover letter patch produced by git-format-patch --cover-letter; It is initialized with subject suffix " *** SUBJECT HERE ***" and body prefix

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: > Check if a file argument is a cover letter patch produced by > git-format-patch --cover-letter; It is initialized with subject suffix " > *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they > exist, warn the use

[PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

Check if a file argument is a cover letter patch produced by git-format-patch --cover-letter; It is initialized with subject suffix " *** SUBJECT HERE ***" and body prefix " *** BLURB HERE ***". If they exist, warn the user. Signed-off-by: Manos Pitsidianakis --- Range-diff against v1: 1: 64b7ec