Re: [PATCH v2] qga: return a more explicit error on why a command is disabled

2021-02-18 Thread Marc-André Lureau
Hi On Thu, Feb 18, 2021 at 8:40 PM Markus Armbruster wrote: > marcandre.lur...@redhat.com writes: > > > From: Marc-André Lureau > > > > qmp_disable_command() now takes an enum for the reason, to be able > > to give more explicit error messages. > > > > Fixes: > > https://bugzilla.redhat.com/sho

Re: [PATCH v2] qga: return a more explicit error on why a command is disabled

2021-02-18 Thread Markus Armbruster
marcandre.lur...@redhat.com writes: > From: Marc-André Lureau > > qmp_disable_command() now takes an enum for the reason, to be able > to give more explicit error messages. > > Fixes: > https://bugzilla.redhat.com/show_bug.cgi?id=1928806 > > Signed-off-by: Marc-André Lureau > --- > > v2: > - re

Re: [PATCH v2] qga: return a more explicit error on why a command is disabled

2021-02-16 Thread no-reply
: return a more explicit error on why a command is disabled === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback b

[PATCH v2] qga: return a more explicit error on why a command is disabled

2021-02-16 Thread marcandre . lureau
From: Marc-André Lureau qmp_disable_command() now takes an enum for the reason, to be able to give more explicit error messages. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1928806 Signed-off-by: Marc-André Lureau --- v2: - replace string with an enum for disabling reason - remove tr