Re: [PATCH v2] qemu-config: add error propagation to qemu_config_parse

2021-03-03 Thread Paolo Bonzini
On 03/03/21 14:48, Markus Armbruster wrote: Reviewed-by: Markus Armbruster But please consider avoiding it anyway. It does make for a smaller patch, so I'll use that as an excuse instead of me being old school. I'll clean it up in a separate patch. Paolo

Re: [PATCH v2] qemu-config: add error propagation to qemu_config_parse

2021-03-03 Thread Markus Armbruster
Paolo Bonzini writes: > This enables some simplification of vl.c via error_fatal, and improves > error messages. Before: > > Before: > $ ./qemu-system-x86_64 -readconfig . > qemu-system-x86_64: error reading file > qemu-system-x86_64: -readconfig .: read config .: Invalid argument > $ /u

Re: [PATCH v2] qemu-config: add error propagation to qemu_config_parse

2021-02-26 Thread Philippe Mathieu-Daudé
On 2/26/21 6:08 PM, Paolo Bonzini wrote: > This enables some simplification of vl.c via error_fatal, and improves > error messages. Before: > > Before: > $ ./qemu-system-x86_64 -readconfig . > qemu-system-x86_64: error reading file > qemu-system-x86_64: -readconfig .: read config .: Invalid

[PATCH v2] qemu-config: add error propagation to qemu_config_parse

2021-02-26 Thread Paolo Bonzini
This enables some simplification of vl.c via error_fatal, and improves error messages. Before: Before: $ ./qemu-system-x86_64 -readconfig . qemu-system-x86_64: error reading file qemu-system-x86_64: -readconfig .: read config .: Invalid argument $ /usr/libexec/qemu-kvm -readconfig foo q