Re: [PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

2023-10-03 Thread Jean-Louis Dupond
On 25/09/2023 16:17, Hanna Czenczek wrote: On 25.09.23 13:40, Jean-Louis Dupond wrote: On 15/09/2023 13:21, Hanna Czenczek wrote: On 05.09.23 15:08, Jean-Louis Dupond wrote: When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is ex

Re: [PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

2023-09-25 Thread Hanna Czenczek
On 25.09.23 13:40, Jean-Louis Dupond wrote: On 15/09/2023 13:21, Hanna Czenczek wrote: On 05.09.23 15:08, Jean-Louis Dupond wrote: When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing,

Re: [PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

2023-09-25 Thread Jean-Louis Dupond
On 15/09/2023 13:21, Hanna Czenczek wrote: On 05.09.23 15:08, Jean-Louis Dupond wrote: When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in t

Re: [PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

2023-09-15 Thread Hanna Czenczek
On 05.09.23 15:08, Jean-Louis Dupond wrote: When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image. When committing the snap

[PATCH v2] qcow2: keep reference on zeroize with discard-no-unref enabled

2023-09-05 Thread Jean-Louis Dupond
When the discard-no-unref flag is enabled, we keep the reference for normal discard requests. But when a discard is executed on a snapshot/qcow2 image with backing, the discards are saved as zero clusters in the snapshot image. When committing the snapshot to the backing file, not discard_in_l2_sl