Re: [PATCH v2] nbd: fix uninitialized variable warning

2020-01-08 Thread Laurent Vivier
Le 08/01/2020 à 03:51, pannengy...@huawei.com a écrit : > From: Pan Nengyuan > > Fixes: > /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request': > /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in > this function [-Werror=maybe-uninitialized] > int ret; >

Re: [PATCH v2] nbd: fix uninitialized variable warning

2020-01-07 Thread Richard Henderson
On 1/8/20 12:51 PM, pannengy...@huawei.com wrote: > From: Pan Nengyuan > > Fixes: > /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request': > /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in > this function [-Werror=maybe-uninitialized] > int ret; > > Repo

[PATCH v2] nbd: fix uninitialized variable warning

2020-01-07 Thread pannengyuan
From: Pan Nengyuan Fixes: /mnt/sdb/qemu/nbd/server.c: In function 'nbd_handle_request': /mnt/sdb/qemu/nbd/server.c:2313:9: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] int ret; Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- Changes v2 to

Re: [Qemu-devel] [PATCH v2] nbd: fix uninitialized variable warning

2019-07-19 Thread Eric Blake
On 7/16/19 5:07 AM, Marc-André Lureau wrote: > ../block/nbd.c: In function 'nbd_co_request': > ../block/nbd.c:745:8: error: 'local_reply.type' may be used uninitialized in > this function [-Werror=maybe-uninitialized] > if (chunk->type == NBD_REPLY_TYPE_NONE) { > ^ > ../block/nbd.c:71

Re: [Qemu-devel] [PATCH v2] nbd: fix uninitialized variable warning

2019-07-16 Thread Eric Blake
On 7/16/19 5:21 AM, Philippe Mathieu-Daudé wrote: > I was writing on your v1 "it might be worth commenting this is when > building with -O3" > > This might be as easy as having the subject modified (by maintainer > taking this patch?) as: > > "fix uninitialized variable warning [when building wit

Re: [Qemu-devel] [PATCH v2] nbd: fix uninitialized variable warning

2019-07-16 Thread Philippe Mathieu-Daudé
I was writing on your v1 "it might be worth commenting this is when building with -O3" This might be as easy as having the subject modified (by maintainer taking this patch?) as: "fix uninitialized variable warning [when building with -O3]" On 7/16/19 12:07 PM, Marc-André Lureau wrote: > ../bloc

[Qemu-devel] [PATCH v2] nbd: fix uninitialized variable warning

2019-07-16 Thread Marc-André Lureau
../block/nbd.c: In function 'nbd_co_request': ../block/nbd.c:745:8: error: 'local_reply.type' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (chunk->type == NBD_REPLY_TYPE_NONE) { ^ ../block/nbd.c:710:14: note: 'local_reply.type' was declared here NBD