RE: [PATCH v2] migration: refactor migration_completion

2023-10-12 Thread Wang, Wei W
On Wednesday, October 11, 2023 8:41 PM, Juan Quintela wrote: > Wei Wang wrote: > > Current migration_completion function is a bit long. Refactor the long > > implementation into different subfunctions: > > - migration_completion_precopy: completion code related to precopy > > - migration_completio

RE: [PATCH v2] migration: refactor migration_completion

2023-10-12 Thread Wang, Wei W
On Thursday, October 12, 2023 4:32 AM, Juan Quintela wrote: > > Yeah, this generates a nicer diff, thanks. > > I'll rebase and resend it. > > Already on the pull request. > > I have to fix the conflict, but it has the same changes that yours as far as > I can > see. Yes, just need to remove the

Re: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Juan Quintela
"Wang, Wei W" wrote: > On Wednesday, October 11, 2023 8:41 PM, Juan Quintela wrote: >> Wei Wang wrote: >> > Current migration_completion function is a bit long. Refactor the long >> > implementation into different subfunctions: >> > - migration_completion_precopy: completion code related to preco

RE: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Wang, Wei W
On Wednesday, October 11, 2023 8:41 PM, Juan Quintela wrote: > Wei Wang wrote: > > Current migration_completion function is a bit long. Refactor the long > > implementation into different subfunctions: > > - migration_completion_precopy: completion code related to precopy > > - migration_completio

Re: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Juan Quintela
Wei Wang wrote: > Current migration_completion function is a bit long. Refactor the long > implementation into different subfunctions: > - migration_completion_precopy: completion code related to precopy > - migration_completion_postcopy: completion code related to postcopy > - close_return_path_o

Re: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Juan Quintela
Wei Wang wrote: > Current migration_completion function is a bit long. Refactor the long > implementation into different subfunctions: > - migration_completion_precopy: completion code related to precopy > - migration_completion_postcopy: completion code related to postcopy > - close_return_path_o

RE: [PATCH v2] migration: refactor migration_completion

2023-10-11 Thread Wang, Wei W
On Friday, August 4, 2023 9:37 PM, Peter Xu wrote: Fri, Aug 04, 2023 at 05:30:53PM +0800, Wei Wang wrote: > > Current migration_completion function is a bit long. Refactor the long > > implementation into different subfunctions: > > - migration_completion_precopy: completion code related to precopy

Re: [PATCH v2] migration: refactor migration_completion

2023-08-14 Thread Isaku Yamahata
On Fri, Aug 04, 2023 at 05:30:53PM +0800, Wei Wang wrote: > Current migration_completion function is a bit long. Refactor the long > implementation into different subfunctions: > - migration_completion_precopy: completion code related to precopy > - migration_completion_postcopy: completion code

Re: [PATCH v2] migration: refactor migration_completion

2023-08-04 Thread Peter Xu
On Fri, Aug 04, 2023 at 05:30:53PM +0800, Wei Wang wrote: > Current migration_completion function is a bit long. Refactor the long > implementation into different subfunctions: > - migration_completion_precopy: completion code related to precopy > - migration_completion_postcopy: completion code re

[PATCH v2] migration: refactor migration_completion

2023-08-04 Thread Wei Wang
Current migration_completion function is a bit long. Refactor the long implementation into different subfunctions: - migration_completion_precopy: completion code related to precopy - migration_completion_postcopy: completion code related to postcopy - close_return_path_on_source: rp thread related