05.03.2024 22:56, Fabiano Rosas :
Commit bc38feddeb ("io: fsync before closing a file channel") added a
Fixes: bc38feddeb ("io: fsync before closing a file channel")
FWIW, this is commit c05dfcb7f2 in master, not bc38feddeb.
It's too late to change that now though.
/mjt
Peter Xu writes:
> On Tue, Mar 05, 2024 at 04:56:29PM -0300, Fabiano Rosas wrote:
>> Commit bc38feddeb ("io: fsync before closing a file channel") added a
>> fsync/fdatasync at the closing point of the QIOChannelFile to ensure
>> integrity of the migration stream in case of QEMU crash.
>>
>> The
On Tue, Mar 05, 2024 at 04:56:29PM -0300, Fabiano Rosas wrote:
> Commit bc38feddeb ("io: fsync before closing a file channel") added a
> fsync/fdatasync at the closing point of the QIOChannelFile to ensure
> integrity of the migration stream in case of QEMU crash.
>
> The decision to do the sync a
Commit bc38feddeb ("io: fsync before closing a file channel") added a
fsync/fdatasync at the closing point of the QIOChannelFile to ensure
integrity of the migration stream in case of QEMU crash.
The decision to do the sync at qio_channel_close() was not the best
since that function runs in the ma
