Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-27 Thread gudkov . andrei--- via
On Sat, Aug 26, 2023 at 04:32:01PM +0800, Yong Huang wrote: > Hi, Andrei. I'm preparing a patchset for a pull request. > > For this patch, would you mind if I? > 1. Generate a single patch from the optimization partition. > 2. In the patch above, include my comment and my "Reviewed-by". > 3. Add i

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-26 Thread Yong Huang
Hi, Andrei. I'm preparing a patchset for a pull request. For this patch, would you mind if I? 1. Generate a single patch from the optimization partition. 2. In the patch above, include my comment and my "Reviewed-by". 3. Add it to the queue with other patchsets. Then you can improve on top at you

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-09 Thread Yong Huang
On Wed, Aug 9, 2023 at 11:03 PM wrote: > On Sun, Aug 06, 2023 at 02:16:34PM +0800, Yong Huang wrote: > > On Fri, Aug 4, 2023 at 11:03 PM Andrei Gudkov > > wrote: > > > > > Introduces alternative argument calc-time-ms, which is the > > > the same as calc-time but accepts millisecond value. > > >

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-09 Thread Yong Huang
On Wed, Aug 9, 2023 at 9:59 PM wrote: > On Sun, Aug 06, 2023 at 02:31:43PM +0800, Yong Huang wrote: > > On Sat, Aug 5, 2023 at 2:05 AM Markus Armbruster > wrote: > > > > > Andrei Gudkov writes: > > > > > > > Introduces alternative argument calc-time-ms, which is the > > > > the same as calc-tim

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-09 Thread Peter Xu
On Wed, Aug 09, 2023 at 06:02:52PM +0300, gudkov.and...@huawei.com wrote: > > Not for the patch, I'm just curious about how the predication > > decides the network throughput, I mean QEMU predicts > > if migration will converge based on how fast it sends the data, > > not the actual bandwidth of th

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-09 Thread gudkov . andrei--- via
On Sun, Aug 06, 2023 at 02:16:34PM +0800, Yong Huang wrote: > On Fri, Aug 4, 2023 at 11:03 PM Andrei Gudkov > wrote: > > > Introduces alternative argument calc-time-ms, which is the > > the same as calc-time but accepts millisecond value. > > Millisecond granularity allows to make predictions whe

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-09 Thread gudkov . andrei--- via
On Sun, Aug 06, 2023 at 02:31:43PM +0800, Yong Huang wrote: > On Sat, Aug 5, 2023 at 2:05 AM Markus Armbruster wrote: > > > Andrei Gudkov writes: > > > > > Introduces alternative argument calc-time-ms, which is the > > > the same as calc-time but accepts millisecond value. > > > Millisecond gran

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-05 Thread Yong Huang
On Sat, Aug 5, 2023 at 2:05 AM Markus Armbruster wrote: > Andrei Gudkov writes: > > > Introduces alternative argument calc-time-ms, which is the > > the same as calc-time but accepts millisecond value. > > Millisecond granularity allows to make predictions whether > > migration will succeed or n

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-05 Thread Yong Huang
On Fri, Aug 4, 2023 at 11:03 PM Andrei Gudkov wrote: > Introduces alternative argument calc-time-ms, which is the > the same as calc-time but accepts millisecond value. > Millisecond granularity allows to make predictions whether > migration will succeed or not. To do this, calculate dirty > rate

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-04 Thread Markus Armbruster
Andrei Gudkov writes: > Introduces alternative argument calc-time-ms, which is the > the same as calc-time but accepts millisecond value. > Millisecond granularity allows to make predictions whether > migration will succeed or not. To do this, calculate dirty > rate with calc-time-ms set to max a

Re: [PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-04 Thread Peter Xu
On Fri, Aug 04, 2023 at 06:03:27PM +0300, Andrei Gudkov wrote: > Introduces alternative argument calc-time-ms, which is the > the same as calc-time but accepts millisecond value. > Millisecond granularity allows to make predictions whether > migration will succeed or not. To do this, calculate dirt

[PATCH v2] migration/calc-dirty-rate: millisecond-granularity period

2023-08-04 Thread Andrei Gudkov via
Introduces alternative argument calc-time-ms, which is the the same as calc-time but accepts millisecond value. Millisecond granularity allows to make predictions whether migration will succeed or not. To do this, calculate dirty rate with calc-time-ms set to max allowed downtime, convert measured