Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-18 Thread Alex Williamson
On Mon, 18 Nov 2019 19:44:30 -0200 Marcelo Tosatti wrote: > On Sun, Nov 17, 2019 at 11:12:43AM +0100, Paolo Bonzini wrote: > > On 17/11/19 05:31, Alex Williamson wrote: > > > The 'merge' option gives me a similar error. The 'delay' option is > > > the only other choice where I can actually sta

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-18 Thread Paolo Bonzini
On 18/11/19 22:44, Marcelo Tosatti wrote: > Second patch blocks NTPd from synchronizing to a source at all > (can't even confirm if it fails to synchronize after a while). > > Problem seems to be that calling from timer interrupt path: > >/* > * if the periodic timer's update is due to p

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-18 Thread Marcelo Tosatti
On Sun, Nov 17, 2019 at 11:12:43AM +0100, Paolo Bonzini wrote: > On 17/11/19 05:31, Alex Williamson wrote: > > The 'merge' option gives me a similar error. The 'delay' option is > > the only other choice where I can actually start the VM, but this > > results in the commandline: > > > > -rtc base

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-17 Thread Alex Williamson
On Sun, 17 Nov 2019 11:12:43 +0100 Paolo Bonzini wrote: > On 17/11/19 05:31, Alex Williamson wrote: > > The 'merge' option gives me a similar error. The 'delay' option is > > the only other choice where I can actually start the VM, but this > > results in the commandline: > > > > -rtc base=loca

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-17 Thread Paolo Bonzini
On 17/11/19 05:31, Alex Williamson wrote: > The 'merge' option gives me a similar error. The 'delay' option is > the only other choice where I can actually start the VM, but this > results in the commandline: > > -rtc base=localtime > > (no driftfix specified) none is the default, so that's oka

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-16 Thread Alex Williamson
On Sun, 17 Nov 2019 01:20:19 -0200 Marcelo Tosatti wrote: > On Sat, Nov 16, 2019 at 01:58:55PM -0700, Alex Williamson wrote: > > On Thu, 10 Oct 2019 09:30:08 -0300 > > Marcelo Tosatti wrote: > > > > > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > > > reinjection when

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-16 Thread Marcelo Tosatti
On Sat, Nov 16, 2019 at 01:58:55PM -0700, Alex Williamson wrote: > On Thu, 10 Oct 2019 09:30:08 -0300 > Marcelo Tosatti wrote: > > > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > > reinjection when there is no period change by the guest. > > > > In that case, old_period

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-11-16 Thread Alex Williamson
On Thu, 10 Oct 2019 09:30:08 -0300 Marcelo Tosatti wrote: > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > reinjection when there is no period change by the guest. > > In that case, old_period is 0, which ends up zeroing irq_coalesced > (counter of reinjected interrupts)

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/24/19 1:22 PM, Philippe Mathieu-Daudé wrote: On 10/10/19 2:30 PM, Marcelo Tosatti wrote: commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt reinjection when there is no period change by the guest. In that case, old_period is 0, which ends up zeroing irq_coalesced (coun

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-10-24 Thread Philippe Mathieu-Daudé
On 10/10/19 2:30 PM, Marcelo Tosatti wrote: commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt reinjection when there is no period change by the guest. In that case, old_period is 0, which ends up zeroing irq_coalesced (counter of reinjected interrupts). The consequence is W

Re: [PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-10-10 Thread Paolo Bonzini
On 10/10/19 14:30, Marcelo Tosatti wrote: > > commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt > reinjection when there is no period change by the guest. > > In that case, old_period is 0, which ends up zeroing irq_coalesced > (counter of reinjected interrupts). > > The cons

[PATCH v2] mc146818rtc: fix timer interrupt reinjection

2019-10-10 Thread Marcelo Tosatti
commit 369b41359af46bded5799c9ef8be2b641d92e043 broke timer interrupt reinjection when there is no period change by the guest. In that case, old_period is 0, which ends up zeroing irq_coalesced (counter of reinjected interrupts). The consequence is Windows 7 is unable to synchronize time via NT