Re: [PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Andreas Schwab
On Mär 29 2023, Philippe Mathieu-Daudé wrote: > On 29/3/23 16:00, Daniel P. Berrangé wrote: >> On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: >>> Do not reverse the order of environment variables in the target environ >>> array relative to the incoming environ order. Some testsui

Re: [PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Warner Losh
On Wed, Mar 29, 2023, 4:00 PM Daniel P. Berrangé wrote: > On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: > > Do not reverse the order of environment variables in the target environ > > array relative to the incoming environ order. Some testsuites depend on > a > > specific order

Re: [PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Daniel P . Berrangé
On Wed, Mar 29, 2023 at 04:04:43PM +0200, Andreas Schwab wrote: > On Mär 29 2023, Daniel P. Berrangé wrote: > > > On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: > >> Do not reverse the order of environment variables in the target environ > >> array relative to the incoming environ

Re: [PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Andreas Schwab
On Mär 29 2023, Daniel P. Berrangé wrote: > On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: >> Do not reverse the order of environment variables in the target environ >> array relative to the incoming environ order. Some testsuites depend on a >> specific order, even though it is

Re: [PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Philippe Mathieu-Daudé
On 29/3/23 16:00, Daniel P. Berrangé wrote: On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: Do not reverse the order of environment variables in the target environ array relative to the incoming environ order. Some testsuites depend on a specific order, even though it is not def

Re: [PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Daniel P . Berrangé
On Wed, Mar 29, 2023 at 03:55:13PM +0200, Andreas Schwab wrote: > Do not reverse the order of environment variables in the target environ > array relative to the incoming environ order. Some testsuites depend on a > specific order, even though it is not defined by any standard. > > Signed-off-by:

[PATCH v2] linux-user: preserve incoming order of environment variables in the target

2023-03-29 Thread Andreas Schwab
Do not reverse the order of environment variables in the target environ array relative to the incoming environ order. Some testsuites depend on a specific order, even though it is not defined by any standard. Signed-off-by: Andreas Schwab --- linux-user/main.c | 6 ++ 1 file changed, 6 inse