Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-22 Thread Richard Henderson
On 11/20/24 15:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments via memory. Fix by sharing the detection logic betw

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread iii
On 2024-11-21 11:07, Philippe Mathieu-Daudé wrote: On 21/11/24 10:26, iii wrote: On 2024-11-21 10:00, Philippe Mathieu-Daudé wrote: On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does n

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread iii
On 2024-11-21 10:00, Philippe Mathieu-Daudé wrote: On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread Philippe Mathieu-Daudé
On 21/11/24 10:26, iii wrote: On 2024-11-21 10:00, Philippe Mathieu-Daudé wrote: On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but m

Re: [PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-21 Thread Philippe Mathieu-Daudé
On 20/11/24 22:26, Ilya Leoshkevich wrote: print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments via memory. Fix by sharing the detection logic betw

[PATCH v2] linux-user: Fix strace output for s390x mmap()

2024-11-20 Thread Ilya Leoshkevich
print_mmap() assumes that mmap() receives arguments via memory if mmap2() is present. s390x (as opposed to s390) does not fit this pattern: it does not have mmap2(), but mmap() still receives arguments via memory. Fix by sharing the detection logic between syscall.c and strace.c. Cc: qemu-sta...@