Re: [PATCH v2] linux-user: Clean up arg_start/arg_end confusion

2022-05-22 Thread Laurent Vivier
Le 27/04/2022 à 04:51, Richard Henderson a écrit : We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second pair

Re: [PATCH v2] linux-user: Clean up arg_start/arg_end confusion

2022-05-22 Thread Philippe Mathieu-Daudé via
On 27/4/22 04:51, Richard Henderson wrote: We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second pair to the

Re: [PATCH v2] linux-user: Clean up arg_start/arg_end confusion

2022-05-20 Thread Richard Henderson
Ping? r~ On 4/26/22 19:51, Richard Henderson wrote: We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second p

[PATCH v2] linux-user: Clean up arg_start/arg_end confusion

2022-04-26 Thread Richard Henderson
We had two sets of variables: arg_start/arg_end, and arg_strings/env_strings. In linuxload.c, we set the first pair to the bounds of the argv strings, but in elfload.c, we set the first pair to the bounds of the argv pointers and the second pair to the bounds of the argv strings. Remove arg_start