Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Thomas Huth
On 12/04/2021 16.35, Thomas Huth wrote: On 12/04/2021 16.21, Stefan Hajnoczi wrote: On Mon, Apr 12, 2021 at 11:35:40AM +0200, Thomas Huth wrote: On 12/04/2021 11.18, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to pa

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Thomas Huth
On 12/04/2021 16.21, Stefan Hajnoczi wrote: On Mon, Apr 12, 2021 at 11:35:40AM +0200, Thomas Huth wrote: On 12/04/2021 11.18, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTES

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Stefan Hajnoczi
On Mon, Apr 12, 2021 at 11:35:40AM +0200, Thomas Huth wrote: > On 12/04/2021 11.18, Stefan Hajnoczi wrote: > > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > > qtest_get_arch(), which attempts to parse the target architecture from > > the QTEST_QEMU_BINARY environment variable

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Peter Maydell
On Mon, 12 Apr 2021 at 10:35, Thomas Huth wrote: > > On 12/04/2021 11.18, Stefan Hajnoczi wrote: > > Some downstreams rename the QEMU binary to "qemu-kvm". This breaks > > qtest_get_arch(), which attempts to parse the target architecture from > > the QTEST_QEMU_BINARY environment variable. > > > >

Re: [PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Thomas Huth
On 12/04/2021 11.18, Stefan Hajnoczi wrote: Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things fai

[PATCH v2] libqtest: refuse QTEST_QEMU_BINARY=qemu-kvm

2021-04-12 Thread Stefan Hajnoczi
Some downstreams rename the QEMU binary to "qemu-kvm". This breaks qtest_get_arch(), which attempts to parse the target architecture from the QTEST_QEMU_BINARY environment variable. Print an error instead of returning the architecture "kvm". Things fail in weird ways when the architecture string i