Re: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-16 Thread Philippe Mathieu-Daudé
riginal Message- >>>>>> From: Chenzhendong (alex) >>>>>> Sent: Friday, November 13, 2020 10:55 PM >>>>>> To: arm...@redhat.com >>>>>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org; >>>>>> qemu-triv...@nongn

Re: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-16 Thread Markus Armbruster
;>>> Sent: Friday, November 13, 2020 10:55 PM >>>>> To: arm...@redhat.com >>>>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org; >>>>> qemu-triv...@nongnu.org; Zhanghailiang ; >>>>> Chenqun (kuhn) >>>>> Subject:

Re: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-16 Thread Alex Chen
:55 PM >>>> To: arm...@redhat.com >>>> Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org; >>>> qemu-triv...@nongnu.org; Zhanghailiang ; >>>> Chenqun (kuhn) >>>> Subject: [PATCH v2] json: Fix a memleak in parse_pair() >>>> >>&

Re: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-16 Thread Philippe Mathieu-Daudé
g (alex) ; qemu-devel@nongnu.org; >>> qemu-triv...@nongnu.org; Zhanghailiang ; >>> Chenqun (kuhn) >>> Subject: [PATCH v2] json: Fix a memleak in parse_pair() >>> >>> In qobject_type(), NULL is returned when the 'QObject' returned from >>> pars

Re: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-15 Thread Markus Armbruster
>> Chenqun (kuhn) >> Subject: [PATCH v2] json: Fix a memleak in parse_pair() >> >> In qobject_type(), NULL is returned when the 'QObject' returned from >> parse_value() is not of QString type, and this 'QObject' memory will leaked. >> So we n

RE: [PATCH v2] json: Fix a memleak in parse_pair()

2020-11-14 Thread Chenqun (kuhn)
> -Original Message- > From: Chenzhendong (alex) > Sent: Friday, November 13, 2020 10:55 PM > To: arm...@redhat.com > Cc: Chenzhendong (alex) ; qemu-devel@nongnu.org; > qemu-triv...@nongnu.org; Zhanghailiang ; > Chenqun (kuhn) > Subject: [PATCH v2] json: Fix

[PATCH v2] json: Fix a memleak in parse_pair()

2020-11-13 Thread Alex Chen
In qobject_type(), NULL is returned when the 'QObject' returned from parse_value() is not of QString type, and this 'QObject' memory will leaked. So we need to first cache the 'QObject' returned from parse_value(), and finally free 'QObject' memory at the end of the function. Also, we add a testca