Re: [PATCH v2] hw/riscv: fix build error with clang

2024-11-06 Thread Daniel Henrique Barboza
On 11/5/24 7:55 PM, Philippe Mathieu-Daudé wrote: On 5/11/24 05:29, Pierrick Bouvier wrote: Thanks for the review. Feel free to pull the patch in your next PR, so it can be available for release 9.2. Regards, Pierrick On 11/4/24 18:37, Alistair Francis wrote: On Tue, Nov 5, 2024 at 8:23 A

Re: [PATCH v2] hw/riscv: fix build error with clang

2024-11-05 Thread Philippe Mathieu-Daudé
On 5/11/24 05:29, Pierrick Bouvier wrote: Thanks for the review. Feel free to pull the patch in your next PR, so it can be available for release 9.2. Regards, Pierrick On 11/4/24 18:37, Alistair Francis wrote: On Tue, Nov 5, 2024 at 8:23 AM Pierrick Bouvier wrote: Introduced in 0c54ac, "h

Re: [PATCH v2] hw/riscv: fix build error with clang

2024-11-04 Thread Pierrick Bouvier
Thanks for the review. Feel free to pull the patch in your next PR, so it can be available for release 9.2. Regards, Pierrick On 11/4/24 18:37, Alistair Francis wrote: On Tue, Nov 5, 2024 at 8:23 AM Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation"

Re: [PATCH v2] hw/riscv: fix build error with clang

2024-11-04 Thread LIU Zhiwei
On 2024/11/5 06:22, Pierrick Bouvier wrote: Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext) | ^ D:/a/_temp/msys64/clan

Re: [PATCH v2] hw/riscv: fix build error with clang

2024-11-04 Thread Alistair Francis
On Tue, Nov 5, 2024 at 8:23 AM Pierrick Bouvier wrote: > > Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" > > ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' > > 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext) > > | ^ > >

[PATCH v2] hw/riscv: fix build error with clang

2024-11-04 Thread Pierrick Bouvier
Introduced in 0c54ac, "hw/riscv: add RISC-V IOMMU base emulation" ../hw/riscv/riscv-iommu.c:187:17: error: redefinition of '_pext_u64' 187 | static uint64_t _pext_u64(uint64_t val, uint64_t ext) | ^ D:/a/_temp/msys64/clang64/lib/clang/18/include/bmi2intrin.h:217:1: note: