Re: [PATCH v2] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread Bernhard Beschow
Am 5. Januar 2023 17:37:02 UTC schrieb "Philippe Mathieu-Daudé" : >No need to document magic values when the definition names >from "standard-headers/linux/pci_regs.h" are self-explicit. > >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/pci-host/grackle.c | 2 +- > hw/pci-host/raven.c|

Re: [PATCH v2] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread Richard Henderson
On 1/5/23 09:37, Philippe Mathieu-Daudé wrote: No need to document magic values when the definition names from "standard-headers/linux/pci_regs.h" are self-explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 2 +- hw/pci-host/raven.c| 6 +++--- hw/pci-host/unin

[PATCH v2] hw/pci-host: Use register definitions from PCI standard

2023-01-05 Thread Philippe Mathieu-Daudé
No need to document magic values when the definition names from "standard-headers/linux/pci_regs.h" are self-explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/pci-host/grackle.c | 2 +- hw/pci-host/raven.c| 6 +++--- hw/pci-host/uninorth.c | 33 +++-- 3 fi