Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-06 Thread Klaus Jensen
On Nov 4 17:32, Waldek Kozaczuk wrote: > I have run my tests on the OSv side with small queue sizes like 3,4,5 and I > could NOT replicate the issue. So it looks like the V2 version of this > patch fixes the problem. > Thanks for testing Waldek! May I add a Tested-by tag to the commit for you?

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-04 Thread Waldek Kozaczuk
I have run my tests on the OSv side with small queue sizes like 3,4,5 and I could NOT replicate the issue. So it looks like the V2 version of this patch fixes the problem. Thanks a lot, Waldemar Kozaczuk On Mon, Nov 4, 2024 at 1:57 PM Keith Busch wrote: > On Tue, Oct 29, 2024 at 01:15:19PM +010

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-04 Thread Keith Busch
On Tue, Oct 29, 2024 at 01:15:19PM +0100, Klaus Jensen wrote: > From: Klaus Jensen > > If a host chooses to use the SQHD "hint" in the CQE to know if there is > room in the submission queue for additional commands, it may result in a > situation where there are not enough internal resources (stru

Re: [PATCH v2] hw/nvme: fix handling of over-committed queues

2024-11-04 Thread Klaus Jensen
On Oct 29 13:15, Klaus Jensen wrote: > From: Klaus Jensen > > If a host chooses to use the SQHD "hint" in the CQE to know if there is > room in the submission queue for additional commands, it may result in a > situation where there are not enough internal resources (struct > NvmeRequest) availab

[PATCH v2] hw/nvme: fix handling of over-committed queues

2024-10-29 Thread Klaus Jensen
From: Klaus Jensen If a host chooses to use the SQHD "hint" in the CQE to know if there is room in the submission queue for additional commands, it may result in a situation where there are not enough internal resources (struct NvmeRequest) available to process the command. For a lack of a better