Re: [PATCH v2] hw/core/qdev: Increase qdev_realize() kindness

2020-07-06 Thread Philippe Mathieu-Daudé
On 7/6/20 9:09 AM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: > >> Since commit 510ef98dca5, qdev_realize() aborts if bus-less >> device is realized on a bus. Be kind with the developer by >> displaying a hint about what is wrong. >> >> Signed-off-by: Philippe Mathieu-Daudé >> ---

Re: [PATCH v2] hw/core/qdev: Increase qdev_realize() kindness

2020-07-06 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Since commit 510ef98dca5, qdev_realize() aborts if bus-less > device is realized on a bus. Be kind with the developer by > displaying a hint about what is wrong. > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Use errp (bonzini suggestion) > > Paolo, I was

[PATCH v2] hw/core/qdev: Increase qdev_realize() kindness

2020-07-05 Thread Philippe Mathieu-Daudé
Since commit 510ef98dca5, qdev_realize() aborts if bus-less device is realized on a bus. Be kind with the developer by displaying a hint about what is wrong. Signed-off-by: Philippe Mathieu-Daudé --- v2: Use errp (bonzini suggestion) Paolo, I was tempted to check errp is really &error_abort else